Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • autosubmit autosubmit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 338
    • Issues 338
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • autosubmitautosubmit
  • Merge requests
  • !477

Avoid & as a char of a filename

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged dbeltran requested to merge 4.1.11-Vertical-cyclic into master Aug 26, 2024
  • Overview 6
  • Commits 2
  • Pipelines 0
  • Changes 2

Hello @bdepaula , @egarriga

Closes #1287 (closed)

There is a bug when a filename is written with &; this happens for vertical-mixed wrappers, so I've changed it to _, and now it works.

Not sure how to write a pytest for it, but if we include a vertical-mixed testcase when we implement the regression tests, we should cover it as it was crashing the create command ( and send_command)

https://earth.bsc.es/gitlab/es/autosubmit/-/blob/master/autosubmit/job/job_packages.py#L57

Changing return "&".join(jobs_in_wrapper)

for

return "_".join(jobs_in_wrapper)

works

How to test:

1- Master branch, with an experiment generated with -dm and marenostrum5 platform, and a jobs.yml configured like this:

  SIM:
    SCRIPT: |
      echo sim.sh
    RUNNING: chunk
    PROCESSORS: 4
    DEPENDENCIES:
      PP-1:
    wallclock: 00:10
  PP:
    SCRIPT: |
      echo sim.sh
    RUNNING: chunk
    PROCESSORS: 4
    DEPENDENCIES:
      SIM:
    wallclock: 00:10
WRAPPERS:
  WRAPPER_V:
    TYPE: "vertical"
    JOBS_IN_WRAPPER: "SIM PP"
    MIN_WRAPPED: 2
    MAX_WRAPPED: 16

Try to plot an experiment.

2- With this branch, try the same

Correct filename(this branch): a002_ASThread_SIM_PP_17246553097434_4_6.cmd*

Wrong filename(master): 'a002_ASThread_SIM&PP_17246558988328_4_6.cmd'*

As you can see, it appears '' that makes AS crash.

Edited Aug 26, 2024 by Bruno de Paula Kinoshita
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 4.1.11-Vertical-cyclic