Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • autosubmit autosubmit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 338
    • Issues 338
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • autosubmitautosubmit
  • Merge requests
  • !512

#945: Fix portalocker error handling.

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Bruno de Paula Kinoshita requested to merge gl-945-fix-portalocker-error-handling into master Nov 11, 2024
  • Overview 19
  • Commits 2
  • Pipelines 0
  • Changes 6

Closes #945 (closed)

Related to #1429

This modifies the logic in the central function that captures errors in Autosubmit, used for every autosubmit subcommand. Instead of printing the error and releasing the lock, now it keeps the lock if the error was a portalocker error.

Portalocker is now the only one that locks and unlocks experiments (done automatically via context-manager, when the code finishes or upon a crash/another exception/AutosubmitCritical/etc.). Unless the user or someone/thing deletes the lock file.

  • Tested locally running an experiment for one hour, and testing commands that would have released the lock. Used lslocks -p $PID to confirm the lock was never released.
  • Added tests
Edited Nov 14, 2024 by Bruno de Paula Kinoshita
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gl-945-fix-portalocker-error-handling