Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • startR startR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 29
    • Issues 29
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • startRstartR
  • Merge requests
  • !125

Split Start() into internal functions. Part I

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Nuria Pérez-Zanón requested to merge develop-SplitStart into master Feb 18, 2021
  • Overview 7
  • Commits 6
  • Pipelines 5
  • Changes 5

Hi @aho,

I have moved the code I showed you to this branch. Finally, I have created a file zzz.R to include the internal functions of Start(). Maybe, in the future, we might want to look for another strategy.

Then, I have created the package in my WS using R 3.2.0 and CDO 1.9.8 including the tests. I found that some of them failed so I have reviewed the master branch and it has shown the same errors:

  Running ‘testthat.R’ [29s/32s]
 ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  testthat results ================================================================
  OK: 333 SKIPPED: 173 FAILED: 2
  1. Failure: 1. expid/member/version (@test-Start-path_glob_permissive.R#40) 
  2. Failure: 1. expid/member/version (@test-Start-path_glob_permissive.R#82) 
  

Have you recently tested? Maybe it is due to the R version but I have used R 3.2.0 since is the one specified in the DESCRIPTION file.

Núria

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop-SplitStart