Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • startR startR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • startRstartR
  • Merge requests
  • !158

Fix for the condition statement for sri chunking (transform + chunk)

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged aho requested to merge develop-transform_chunk_sri_chunking into master Nov 17, 2021
  • Overview 0
  • Commits 3
  • Pipelines 2
  • Changes 4

Hi @nperez

This fix is for issue #121 (closed). As the clarification of the problem in the comment in the issue, the actual problem is not about transform + chunk for two datasets, but simply for one dataset in some cases (that the previous unit tests happened not to test out.)

The current method of sri chunking may not be 100% correct still. The difficulty is to know which grid points are the one to pick after transformation. One thing can help is to limit the crop option to only the four numbers of region borders, not TRUE or FALSE. By this means, we can predict the values of sri more.

Anyways, this branch fixes the current bugs identified. We can merge it to master and do the crop development somewhere else. Please let me know if you agree to merge it, thanks.

Cheers,
An-Chi

Edited Nov 17, 2021 by aho
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: develop-transform_chunk_sri_chunking