Skip to content
GitLab

Bugfix for first file missing case. The error happened when retrieving metadata.

Merged aho requested to merge develop-first_file_missing into master

Hi @nperez

This fix is for issue #58 (closed). When the first file is missing, Start() couldn't retrieve the data even the following files exist. The error happened when Start() retrieves metadata from the first file, which does not exist. I don't consider it as a bug because according to the definition of parameter 'metadata_dims',

Start() by default returns the auxiliary data read for only the first file of each source (or data set) in the pattern dimension. Of course it may be better to change the sentence to 'only the first existing file' and improve this situation, but I found it difficult. Therefore, I made the following modification:

  1. When the first file is missing and 'metadata_dims' is not specified, Start() still retrieves the data but does not retrieve the metadata of the variables (that is, for example, the metadata of 'tas' won't be retrieved, while 'lon' and 'lat' etc. can still be retrieved).
  2. Start() returns a warning saying that the metadata is not found, and suggests checking the first file or specifying 'metadata_dims'.

With this enhancement, Start() won't fail when the first file is missing.

Please let me know if there is anything unclear for you. Thanks!

Cheers,
An-Chi