Coverity CID 44803

Coverity CID 44813

Fix of 0ce35824

Before:
$ sbatch --wrap="sleep 300"
Submitted batch job 228
$ squeue
             JOBID PARTITION     NAME     USER ST       TIME   CPUS NODELIST(REASON)
               228     debug     wrap    brian PD       0:00      1 (AssocMaxUnknownPerNode)

Fixed:
$ squeue
             JOBID PARTITION     NAME     USER ST       TIME   CPUS NODELIST(REASON)
               229     debug     wrap    brian PD       0:00      1 (AssocMaxCpuPerNode)

$ sacctmgr mod account stuff set maxtrespernode=cpu=-1,mem=1
$ squeue
             JOBID PARTITION     NAME     USER ST       TIME   CPUS NODELIST(REASON)
               229     debug     wrap    brian PD       0:00      1 (AssocMaxMemPerNode)

$ sbatch --wrap="sleep 300" --gres=blah:2 -pgpu
Submitted batch job 235
$ squeue
             JOBID PARTITION     NAME     USER ST       TIME   CPUS NODELIST(REASON)
               235       gpu     wrap    brian PD       0:00      1 (AssocMaxGRESPerNode)

Coverity CID 177813

bug 3673

Bug 4200.

Make this a fatal(), rather than delaying until a symbol error is thrown
when attempting to load the plugin. Update some docs as well.

Bug 4123.

This has been documented this way for a long time, but not strictly
enforced. Enforce it now. (Of course, the real enforcement is still
present within slurmctld. But this denies you up front with a more
obvious error.)

Bug 4101.

Bug 4199.

GCC now suggest parentheses around assignment used as truth value.
Changed affected assignments.

Coverity CID 44768

Coverity CID 44766

Coverity CID 44744

Coverity CID 44732

Coverity CID 45148

Index is unsigned, but bounds can be signed
Coverity CID 44945 and 44946

Create a slurm_opt_t structure with the common elements from salloc
and sbatch. Add salloc_opt_t, sbatch_opt_t and srun_opt_t with
their individual elements, and add a pointer in slurm_opt_t to
that respective struct when appropriate.

Bug 3745.

Pack jobs will never be scheduled in other configurations

The functionality is now fully integrated into the main Slurm code.

burst_buffer/cray plugin modified to work with changes in Cray UP06
   software release.
Specific changes: Cray software now returns an error if a state_in
   or stage_out script is processed that doesn't actually request a
   stage in or out (previously silently ignored).
Also the warning message about tearing down a buffer that is already
   gone changed.

Original test would increase job time limit, which is not possible
  with a normal user

The combination of the first and second digits in the version designate
the major release. The third digit in the version designates the micro release.
minor release word is removed as being confusing and useless.

Coverity CID 45041

Coverity CID 177770

Need to resolve some build issues