It turns out the start of the reservation can be changed to match the
window of the time we are looking at so we need to keep track of
the real start time to update the correct reservation later on.

Bug 4246

Added more validation logic for updates to node features.
Added node_features_p_node_update_valid() function to node_features plugin.
bug 4294

Modify logic used to get socket/core/thread information from
a common function in slurmd. This common function supports
board count and some additional processors that the task/cgroup
function did not support.

HWLOC v2.0 support also requires commit b5b12af8bde34243e784ebf4fede5396c2bb7b73
bug 3969

The API of hwloc has changed considerably for version 2.0.
For a summary check:
https://github.com/open-mpi/hwloc/wiki/Upgrading-to-v2.0-API


Test for the API version to support both the old and new API.

Signed-off-by: Egbert Eich <eich@freedesktop.org>
Signed-off-by: Egbert Eich <eich@suse.de>

Bug 3968

# Conflicts:
#	src/plugins/node_features/knl_cray/node_features_knl_cray.c

If configured with NodeFeatures=knl_cray and there are non-KNL
nodes which include no features the slurmctld will abort without
this patch when attempting strtok_r(NULL).

bug 4294

instead of sometimes calling functions directly.

instead of sometimes calling functions directly.

instead of sometimes calling functions directly.

As well as jobcomp functions.

This also renames some to match the calls of other things.

Bug 4292

There is more possible this was just low hanging fruit.

This is needed to figure out the unused wall clock time on them.

Bug 4246

No other options use underscores, so make these consistent with
the rest. Both old and new syntax is supported for now.

Change all 'verbose' option output to use dashes, and adjust
the testsuite to match.

Fix a few related documentation errors while here.

Turns out what was there before was completely incorrect.

Bug 4246

If configured with NodeFeatures=knl_cray and there are non-KNL
  nodes which include no features the slurmctld will abort without
  this patch when attemping xstrdup(NULL).
bug 4294

the same id.

There is no /slurm page, this was missed in the new style conversion.

Display the commands that are being exec'd

nodes and didn't specify the cluster.  This shouldn't matter for sacctmgr after
the last commit.

with sacctmgr.

reservations instead of adding them which will create a new record in the
database with correct node indexes.

end_time second in the query, it will be the same as the start time of the
next cluster in the list.