The error messages associated with these are:

/home/tim/slurm/src/common/callerid.c:337:21: warning: address of array 'entryp->d_name' will always evaluate to 'true' [-Wpointer-bool-conversion]
                else if (!entryp->d_name)
                         ~~~~~~~~~^~~~~~
1 warning generated.
/home/tim/slurm/src/common/gres.c:831:19: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
                if ((tmp_uint64 < 0) || (tmp_uint64 >= NO_VAL)) {
                     ~~~~~~~~~~ ^ ~
1 warning generated.
/home/tim/slurm/src/slurmctld/node_mgr.c:1684:26: warning: if statement has empty body [-Wempty-body]
                        if (first_new == NULL);
                                              ^
/home/tim/slurm/src/slurmctld/node_mgr.c:1684:26: note: put the semicolon on a separate line to silence this warning
/home/tim/slurm/src/slurmctld/node_mgr.c:1756:26: warning: if statement has empty body [-Wempty-body]
                        if (first_new == NULL);
                                              ^
/home/tim/slurm/src/slurmctld/node_mgr.c:1756:26: note: put the semicolon on a separate line to silence this warning
/home/tim/slurm/src/slurmctld/node_mgr.c:1830:26: warning: if statement has empty body [-Wempty-body]
                        if (first_new == NULL);
                                              ^
/home/tim/slurm/src/slurmctld/node_mgr.c:1830:26: note: put the semicolon on a separate line to silence this warning
/home/tim/slurm/src/plugins/switch/generic/switch_generic.c:837:27: warning: address of array 'if_rec->ifa_addr->sa_data' will always evaluate to 'true' [-Wpointer-bool-conversion]
                        if (!if_rec->ifa_addr->sa_data)
                            ~~~~~~~~~~~~~~~~~~~^~~~~~~

news

no matter who calls the function.

function to common.c from last commit.

through sacctmgr.

select/cray: Prevent NHC from running more than once per job or step.
bug 2192

In both sched/basic and backfill: If a job can not be started due to some
    account/qos limit, then don't start other jobs which could delay jobs. The
    old logic would skip the job and start other jobs, which could delay the
    higher priority job.
bug 2129

This also corrects per user burst buffer space calculation

_calc_billable_tres that was missed there.

requests no time limit.

http://bugs.schedmd.com/show_bug.cgi?id=2177

Avoid logging every time that some interaction with the elasticsearch
server happens. That would generate too many log messages.
Fix allignment problem in the code without changing logic.

Added a limit of MAX_JOBS 100000 jobs enqueued and waiting to be indexed

Usernames are comma separated, not colon delimited. Bug #2222.
While here fix a few spelling mistakes.

Fixed a typo that was causing slurm_cred_copy to segfault

If a job is configured to be sent a signal when approaching its
timeout and the job is requeued after the signal is sent, then
resend the signal at the approriate time after requeue.
bug 1415

If the backfill scheduler can not start at the appointed time, say
because there are too many pending RPC, then only sleep 1 second
and try again rather than the full bf_interval (30 seconds by default).

Same logic was in both backfill plugin and slurmctld/job_scheduler.c
No change in logic

Bug 2130

Adopted processes didn't have access to the job's devices.

Bug 2130

Full revert of c2fbf88f, 13b64c35 had caught part of this, but
this will revert it completely.  The code just wasn't needed in modern
Slurm.  It appears the patch came from an older version of Slurm that
didn't handle this correctly.

This reverts commit 29f25688.

Conflicts:
	NEWS

Looks like this isn't needed, commit c2fbf88f doesn't appear to be needed
and is what is causing this issue.  c2fbf88f was added from an older
version of Slurm where this was already handled correctly in commit
815e5a44.

get messages like

slurmctld: error: _handle_assoc_tres_run_secs: job 33355: assoc 1 TRES node grp_used_tres_run_secs underflow, tried to remove 21 seconds when only 0 remained.

which are bad.

If a store fails, do not retry for 30 seconds

Cray job NHC delayed until after burst buffer released and epilog completes
    on all allocated nodes.
bugs 2099 and 2192