Fixes GCC 8.2.0 warnings.

Fix some -Werror=restrict and -Werror=format= issues.

Silence GCC 8.2.0 warning.

Nothing modifies this, so don't bother making a copy of it.

Related to GCC 8.2.0 compilation fixes.

Fixes GCC 8.2.0 compilation warnings.

Bug 5465.

MySQL permits up to 64-character database names, but Slurm was truncating
at 33-characters. If we exceed this limit, let the mysql_query fail and
give the admin a chance to sort it out, rather than truncating and then
failing to query against the un-truncated name later on.

While here correct the fatal() message.

Bug 5586.

Bug 5554

Bug 5584

1. The cpu frequency set by the user is not exact with
   current kernels, but close. This changes the logic accordingly.
2. The original logic would cause the test to hang indefinitely
   if the submitted job never ends. This adds timeout checks
   on the job wait, plus adds a 1 minute time limit on the job.
3. Improve/simplify the parsing logic.

Bug 5584

(i.e. gres=gpu/tesla) it would get a count of 0.

Bug 5570

Note that pipe2() is Linux-specific, but this whole cgroup plugin is
already Linux-specific in design, and the eventfd() call itself is
Linux-specific as well.

Bug 5570.

Didn't realize centos 6 was so far behind.

Turns out if you don't close up everything you open the hdf5 lib doesn't
like that.

Fixs regression in 011b2f23.

avoid copying strings that may be overwritten.

Bug 5547

It turns out it is fairly easy with het jobs to hit this and seg fault srun.

Bug 5390

Bug 5547.

Bug 5547.

Causes srun and sattach to fail on big endian platforms.

Bug 5556

Wrong author.

This reverts commit 392e7cfc.

a job with scontrol.

Bug 4964

not work when trying use sattach.

Bug 5556

to run the regression tests 24.* without changing that code since it links
directly to the priority plugin where that function isn't defined.

Bug 5558

Continuation of commit 21d2ab6e

Update slurm.spec and slurm.spec-legacy as well.

Fix NEWS header.

Fixes bad casting caused by Tim on review.

Make one definitive copy of sort_part_tier() in partition_msg.c and use it.

Bug 3844, 5552.

and other drain + node state flags.

Bug 5505

Update slurm.spec and slurm.spec-legacy as well.

Bug 5505

Bug 5164.

Without this patch the slurmctld would send a finishing message to srun
which may already be torn down.  This prevents printing a benign
error message.

Bug 3844.

Bug 5526