Coverity CID 187782

Update slurm.spec and slurm.spec-legacy as well.

This will need to be revisited perhaps link to libslurmfull.so instead
since we will need symbols not exported.

See bug 5605

The previous commit causes erroneous errors to be printed.

test2.14 was made a victim of it.

# Conflicts:
#	src/plugins/jobacct_gather/common/common_jag.c

Bug 5561.

Bug 5538

Bug 5538

This will be handled further in bug 5602

Continuation of 27bf7328

Previous behavior was confusing, and the code path hard to follow.
Rework, and clarify the established behavior in the appropriate man pages.

Bug 4514.

X11 implies Contain, and Contain is incompatible with NoHold as
the Extern step creation will race with the step launches.

Bug 5500.

This reverts commit dcc93022.

This reverts commit b9fb67d8.

CID 187777.
Bug 5593.

scan-build complains about this possibly being used uninitialized with
pthread_join(), but on review the path it identifies as causing that
is impossible. Initialize this anyways in the hopes of surppressing that
warning.

This also randomizes the backup controller port numbers which
were not being handled here for some reason.

Bug 5166

Bug 5426

Bug 5072

Coverity CID 187776

Drop debugging message, full gres_alloc string is printed out already.

Rework prefix handling slightly.

Drop the debugging message here. The calling path above us prints
out the entire gres_alloc string, and I don't think it's necessary
to continue to break out the individual elements like this.

Rework the prefix (now sep) handling as well slightly.

Do a little cleanup around how the separator is handled while here.