- 15 Mar, 2017 1 commit
-
-
Morris Jette authored
bug 3562, see comment 22
-
- 14 Mar, 2017 3 commits
-
-
Danny Auble authored
-
Danny Auble authored
other half go to libslurmdb.so. Turns out in 17.11 if you are using --with-shared-libslurm sacct will link to both libslurmfull.so and libslurmdb.so. In the case of linking to the accounting_storage/slurmdbd plugin it will callback to slurmdbd_defs_init which would be in libslurmdb.so but the call to acct_storage_p_get_connection would call slurm_open_slurmdbd_conn which is in libslurmfull.so and it would xassert on slurmdbd_defs_inited which was set in libslurmdb.so but not in libslurmfull.so. So the moral of the story is don't export half a file in one lib and the other half in a different lib. Perhaps we should only have 1 lib all together, but that isn't the way it is done today. This fixes the issue and has the entire file exported to libslurmfull.so so we should be good. But just a note for the future. This was an unexpected regression caused by commit 5a5347c7.
-
Tim Wickberg authored
-
- 13 Mar, 2017 13 commits
-
-
Alejandro Sanchez authored
Bug 3530 NOTE: there does appear to be other issues here, but we didn't fell comfortable changing this many things in 17.02 for fear of breaking something. This only fixes a bit of the issue as it appears node_scheduler.c has a fuller test for these. In 17.11 I plan to make this a function that will fill in the min, req, max nodes and use it in both places in the code to prevent this from happening again.
-
Alejandro Sanchez authored
Code calls list_find_first to search in resv_list whether the requested name for the new reservation already exists. If it exists, resv_ptr is set with the pointer to the existing reservation. Then the code goto bad_parse label and xfreed that resv_ptr, thus corrupting the list data by freeing the existing reservation. This is fixed by only freeing memory on the new local resv_ptr instead of always freeing memory. xfree is also not sufficient for freeing the memory, we needed to call _del_resv_rec() or we would leak the memory we had transferred from the resv_desc_ptr. This also involved NULLing out the other variables freed after bad_parse, or you would get double frees. Bug 3558.
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
And cleanup code further.
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
- 11 Mar, 2017 3 commits
-
-
Cameron Childress authored
-
Danny Auble authored
-
Danny Auble authored
assoc_mgr_make_tres_str_from_array.
-
- 10 Mar, 2017 10 commits
-
-
Danny Auble authored
-
Danny Auble authored
-
Tim Shaw authored
array task id. This is combination with the previous commit. Bug 3563
-
Danny Auble authored
-
Danny Auble authored
-
Danny Auble authored
-
Danny Auble authored
I also made seff work on a non-standard perl install. I would had loved to do this in multiple commits, but it wasn't that possible.
-
Tim Wickberg authored
-
Danny Auble authored
-
Dominik Bartkiewicz authored
-
- 08 Mar, 2017 10 commits
-
-
Danny Auble authored
moment the dbd is assigning a db_index. Bug 3512 This is a definite culprit of creating runaway jobs.
-
Danny Auble authored
because the dbd is setting a db_index.
-
Danny Auble authored
in the middle of setting db_indexes.
-
Danny Auble authored
multifactor. Almost impossible to make happen, but still a bug.
-
Tim Wickberg authored
The stepd->protocol_version field is not set at this point, if not handled here then the following call to stepd_get_uid will fail as a protocol_version of zero is rejected. This appeared to work in 16.05 and older as the stepd_get_uid() API call used to ignore the invalid protocol_version and return the correct result anyways, but that was fixed in c177ff95. Bug .
-
Tim Shaw authored
to make note of that by making an empty list.
-
Danny Auble authored
req_config it is no longer needed.
-
Tim Shaw authored
correctly with Slurm tools. What this does is replace the incoming string with the gres actually chosen. Continuation of last commit. Bug 3521
-
Tim Shaw authored
gres line for scontrol et al. No real code change yet though, just changing declaration. Bug 3521
-
Tim Wickberg authored
-