build_all_frontend_info() could be called twice unintentionally.

_get_begin_next_month() may be called twice in succession as
a side-effect of the MIN macro. Store in a local variable first.

fed.weight was removed in ae0c71d0.

fed.weight was removed in ae0c71d0 but the packing of it wasn't
removed in the case of a null slurmdb_cluster_rec_t.

Continuation of a6e19307
CID:169658

Since the cluster records are merged into one cluster record in a
federation, the total time needs to account for each cluster's time.

Made obsolete by moving the federation to an async model.

Don't need it anymore. Was used to hosw communications between sibling
clusters.

Previously it was only opening the connections at startup and then if
had something to send to a sibling that it didn't have a connection to.
It's better to have them establish the connection when the cluster is
added to the federation so that it can detect if the cluster is down
later and the clusters can sync jobs when joing the federation.

Since moving to a asynchronous model for submitting jobs in the
federation, LLC doesn't apply anymore. And since LLC was the only flag,
don't display the federation flags in outputs by default anymore.
Leaving the variable in the struct in case it is needed later.

Doesn't apply anymore now that federation communication is asynchronous
and jobs are submitted to all siblings without regards to a cluster's
weight.

I cannot fathom why this was added - this would only have
influenced something if listen() was implemented as an inline
function or a macro, which I don't believe has ever been the
case.

Regardless, on modern Linux systems that limit is set dynamically
through /proc/sys/net/core/somaxconn.

While not POSIX compliant, BSD and Linux platforms have shipped this
function for a long time, and slurmctld/slurmdbd/slurmd have actually
been using the version from libc instead of this local redefinition.

Zero cleanup functions exist within the source, remove all this
dead infrastructure.

bug 3822

Missed sreport in d3ee28fa

Forgot to add the .h changes.
1d20fe77

because it can't get the fed job lock from the origin cluster.

Only storing existing pointers so don't destroy them.

Only realloc and copy if there is something to copy in.

Coverity CID:169529

The sibling should send its job list even it is empty so that the other
sibling can see if any jobs are missing.

Coverity CID:169530, 169531