CID 45023 and 45024.

Fix task:CPU binding logic for some processors. This bug was introduced
in version 16.05.1 to address KNL bunding problem.
bug 2972

Needed due to part_filter_set() calls; without write lock this can race
returning inconsistent results to 'sinfo'.

Bug 2958.

Regression test fixes if SelectTypePlugin not managing memory and no node
    memory size set (defaults to 1 MB per node).

Fix race condition in the account_gather plugin that could result in job
    stuck in COMPLETING state.
bug 2973

Prior logic used to create an advanced reservation based upon a core
  count would ignore the specialized cores. Then when a job tried to
  use the reservation, it would consider the specialized cores and
  not be able to use the core count used in the reservation creation.
  This change considers specialized cores when creating the reservation.

If slurmstepd had been swapped out before upgrade happened it could
  easily lead to SIGBUS at any time after upgrade. Prevent that by
  mlocking it.
bug 2334

SLURM_JOB_RESERVAION environment variables are set for the salloc command.
Document the same environment variables for the salloc, sbatch and srun
commands in their man pages.

Also we are making extern lower case in the api to match this and sacct.

that had a partition in them.

Document that the SLURM_JOB_ACCOUNT and SLURM_JOB_QOS environment variables
    are set for the srun command in its man page.
bug 2945

Document that the SLURM_JOB_ACCOUNT and SLURM_JOB_QOS environment variables
    are set for the salloc and sbatch commands in their man pages.
bug 2945

Document that persistent burst buffers can not be created or destroyed using
    the salloc or srun --bb options.
bug 2404

Missed in b5bba34c

on batch script completes.

(difference between start of job and when it was eligible).

Bug 2939.

Inadvertently broken in commit 05eac196.

Bug 2912.

or failed based on the signal that would always be killing it.

end of the job to do it.

make them using the master job ID instead of the normal job ID.

Treat invalid user ID in AllowUserBoot option of knl.conf file as error
    rather than fatal (log and do not exit).

Prevent slurmctld abort if job is killed or requeued while waiting for
    reboot of its allocated compute nodes. The _wait_boot() would
    reference job_ptr->node_bitmap, which would be NULL.

Bug 2908

Step hasn't been assigned resources, so the select_jobinfo struct
hasn't yet been populated. Calling select_g_step_finish will dereference
causing a segfault.

Bug 2922.

If the user is now allowed to use the partition,
    then do not check that user's group access again for 5 seconds.
bug 2913

Improve partition AllowGroups caching. Update the table of UIDs permitted to
    use a partition based upon it's AllowGroups configuration parameter as new
    valid UIDs are found rather than looking up that user's group information
    for every job they submit, which can involve considerable overhead for
    some systems.
bug 2913

Minimize preempted jobs for configurations with multiple jobs per node.
  Previous logic would preeempt every job on node allocated to pending
  job.
bug 2906

Fix for core selection with job --gres-flags=enforce-binding option.
    Previous logic would in some cases allocate a job zero cores, resulting in
    slurmctld abort.
bug 2808

In commit b8190e5d many places that were mean to be pending step ids
were changed to be extern_step id.  The main problem was when we came up
with the idea of the extern step we reused -1 (INFINITE) for the id.  So
pending steps also appeared to be extern steps as well.  Hopefully this
fixes the situation.

Bug 2907

Start power save thread only after the partition information is read
  in order to avoid trying to interpret the SuspendExcParts configuration
  information before the partition information is available, which would
  result in a slurmctld abort.

bug 2900

Before it was showing it as TBD since pending steps and the extern step
have the same stepid.