Bug 3530

NOTE: there does appear to be other issues here, but we didn't fell comfortable
changing this many things in 17.02 for fear of breaking something.

This only fixes a bit of the issue as it appears node_scheduler.c has a fuller
test for these.  In 17.11 I plan to make this a function that will fill in
the min, req, max nodes and use it in both places in the code to prevent this
from happening again.

Code calls list_find_first to search in resv_list whether the requested
name for the new reservation already exists. If it exists, resv_ptr is
set with the pointer to the existing reservation. Then the code goto
bad_parse label and xfreed that resv_ptr, thus corrupting the list data
by freeing the existing reservation. This is fixed by only freeing memory on the
new local resv_ptr instead of always freeing memory.  xfree is also not
sufficient for freeing the memory, we needed to call _del_resv_rec() or we would
leak the memory we had transferred from the resv_desc_ptr.  This also involved
NULLing out the other variables freed after bad_parse, or you would get
double frees.

Bug 3558.

And cleanup code further.

assoc_mgr_make_tres_str_from_array.

array task id.

This is combination with the previous commit.

Bug 3563

I also made seff work on a non-standard perl install.

I would had loved to do this in multiple commits, but it wasn't that possible.

moment the dbd is assigning a db_index.

Bug 3512

This is a definite culprit of creating runaway jobs.

because the dbd is setting a db_index.

in the middle of setting db_indexes.

multifactor.  Almost impossible to make happen, but still a bug.

The stepd->protocol_version field is not set at this point,
if not handled here then the following call to stepd_get_uid
will fail as a protocol_version of zero is rejected.

This appeared to work in 16.05 and older as the stepd_get_uid()
API call used to ignore the invalid protocol_version and
return the correct result anyways, but that was fixed in c177ff95.

Bug .

to make note of that by making an empty list.

req_config it is no longer needed.

correctly with Slurm tools.

What this does is replace the incoming string with the gres actually chosen.

Continuation of last commit.

Bug 3521

gres line for scontrol et al.  No real code change yet though, just changing
declaration.

Bug 3521

the database.

Remove duplicate lines

bug 3527