- 10 May, 2016 40 commits
-
-
Tim Wickberg authored
Also remove local version of inet_pton/ntop functions hiding behind HAVE_INET_NTOP/PTON. Those are both in POSIX1.2001.
-
Tim Wickberg authored
Delete files, remove from Makefile. Remove stray includes as well to keep build happy.
-
Tim Wickberg authored
-
Tim Wickberg authored
If HAVE_STRNDUP is undefined, please fix your compiler. Replacing strndup with an unbounded strndup is a bad idea, and you should be using xstrndup anyways.
-
Tim Wickberg authored
Will need to audit for <stdbool.h> inclusion later, currently this is indirect sourced through inclusion of "src/common/macros.h".
-
Tim Wickberg authored
These functions are already out of sync with their data-structures; removing lest anyone assume they'll be correct when uncommented.
-
Tim Wickberg authored
Underlying xmalloc will log and abort for us on OOM, none of these checks would ever fire. Remove custom log macros and tidy up.
-
Tim Wickberg authored
-
Tim Wickberg authored
Since the glibc-portion in the #ifdef above uses malloc, malloc here instead to keep the same free() call below.
-
Tim Wickberg authored
strsignal() is POSIX1.2008, and we already relied on <string.h> to provide the correct definition in plugins/launch/slurm/launch_slurm.c .
-
Tim Wickberg authored
O_CLOEXEC is POSIX1.2008, so the macro test and fallback code are no longer necessary. Each functions was only used once, so replace with equivalent calls to open().
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
This has never been used since addition a decade ago.
-
Tim Wickberg authored
Automatically found by looking for files relying on macro definitions from config.h. Ugly one-liners used to automate this are: tim@zoidberg:~/slurm$ for def in $(grep undef config.h.in |cut -f 2 -d ' ' ); do for f in $(grep -r $def src/ |cut -f 1 -d : | sort -u); do if [ $(grep -q "#include \"config.h\"" $f; echo $? ) -ne 0 ]; then echo $def $f ; fi ; done ; done > missing-includes tim@zoidberg:~/slurm$ for aaa in $(grep -v \.in missing-includes | grep -v \.am |grep SLURM_VERSION|grep -v malloc |cut -f 2 -d ' '|sort -u ); do vim $aaa ; done tim@zoidberg:~/slurm$ for aaa in $(grep -v \.in missing-includes | grep -v \.am |grep -v VERSION|grep -v malloc |cut -f 2 -d ' '|sort -u ); do vim $aaa ; done
-
Tim Wickberg authored
abort() call removed back in commit 94384552.
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
It turns out that autogen.sh is just going to put these right back in. This reverts commit cb37e64864b706b7c14851d03e509ef237db1813.
-
Tim Wickberg authored
config.h.in: <inttypes.h> required and includes PRIu64. smd_ns.h: remove local bool redefinition. Always pick stdbool.h. Alphabetize. testsuite: cleanup includes as well while here.
-
Tim Wickberg authored
Goodbye to: HAVE_DIRENT_H HAVE_ERRNO_H HAVE_FLOAT_H HAVE_HSTRERROR HAVE_LIMITS_H HAVE_MCHECK_H HAVE_MTRACE HAVE_NETDB_H HAVE_PTHREAD_H HAVE_SECURITY_PAM_APPL_H HAVE_SOCKET_H HAVE_STRSIGNAL HAVE_SYSINT_H HAVE_SYS_IPC_H HAVE_SYS_SEM_H HAVE_SYS_SHM_H HAVE_VALUES_H
-
Tim Wickberg authored
<syslog.h> already in use throughout Slurm. Also remove #include "config.h" where no longer required.
-
Tim Wickberg authored
C99 says this keyword exists, stop hiding it behind a macro.
-
Tim Wickberg authored
Continuation on previous patch, but for files that require review. Most of these were just using a local #if _DEBUG and/or protecting against multiple inclusion with #ifndef _PROTECT_H; #define _PROTECT_H. Some also have __APPLE__ or __FreeBSD__ blocks, but those are not in config.h.
-
Tim Wickberg authored
Found semi-automatically with: for a in $( for i in $(grep -r \"config.h\"|cut -f 1 -d : ) ; \ do echo -n "$i "; grep '#if' $i | wc -l ; done \ |grep \ 0 |cut -f 1 -d ' ' ) ; do vim $a ; done
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
POSIX, Linux, FreeBSD all agree setpgrp(0, 0) is equivalent to setpgid(0, 0), and setpgrp() is deprecated in POSIX.
-
Tim Wickberg authored
As of this commit these are all removed from src: HAVE_UNISTD WITH_PTHREAD HAVE_LIMITS HAVE_STRING HAVE_SYS_TYPES_H HAVE_SYS_SOCKET_H
-
Tim Wickberg authored
Continue sorting system includes and un-#ifdef'ing a few additional headers. (HAVE_STRING, HAVE_UNISTD, HAVE_LIMITS, HAVE_PTHREAD). Unconditionally define _GNU_SOURCE when used. Should audit use of this further and possibly define this in config.h directly along with POSIX macros. Remove last vestige of src/common/malloc.[ch].
-
Tim Wickberg authored
Needed for isspace()
-
Tim Wickberg authored
-
Tim Wickberg authored
Anything that is contigent on "if (!HAVE_MALLOC)" is a bad idea. Plus, these aren't actually used by anything. Remove files and stop building them.
-
Tim Wickberg authored
Always include "config.h". Rearrange standard library includes while here, and clean up some additional ifdef contamination missed on the first pass.
-
Tim Wickberg authored
Cleanup the other directories in src/. Remove WITH_PTHREAD from configure as well while here.
-
Tim Wickberg authored
Require <pthread.h> and cleanup #ifdef blocks. Sort system includes.
-
Tim Wickberg authored
Remove local mutex_* macros. Require <pthread.h> and fixup includes.
-
Tim Wickberg authored
Remove list_mutex_* macros. Require <pthread.h> and remove WITH_PTHREAD
-