This reverts commit 7e5d3d15.

Turns out the spank_task_privileged needs to execute inside the child
process instead of the slurmstepd.

Bug 4298

If configured with NodeFeatures=knl_cray and there are non-KNL
nodes which include no features the slurmctld will abort without
this patch when attempting strtok_r(NULL).

bug 4294

Bug 4279

Before it would allow all sorts of things like
adding/subtracting/multiplying/etc.  It would cause warnings such as

/home/bart/slurm-tmp5/src/common/layouts_mgr.c: In function ‘_layouts_load_automerge’:
/home/bart/slurm-tmp5/src/common/layouts_mgr.c:363:21: error: ‘*’ in boolean context, suggest ‘&&’ instead [-Werror=int-in-bool-context]
   *lvalue = *lvalue * *rvalue;     \
             ~~~~~~~~^~~~
/home/bart/slurm-tmp5/src/common/layouts_mgr.c:1034:4: note: in expansion of macro ‘_entity_update_kv_helper’
    _entity_update_kv_helper(type_t, operator); \
    ^~~~~~~~~~~~~~~~~~~~~~~~
/home/bart/slurm-tmp5/src/common/layouts_mgr.c:1086:4: note: in expansion of macro ‘_layouts_load_merge’
    _layouts_load_merge(bool, s_p_get_boolean);
[tag] [reply] [−] Private Comment 16

Bug 4062

Setting -Werror tricks the test into failing on the

"error: In the GNU C Library, "major" is defined by <sys/sysmacros.h>.
 For historical compatibility, it is  currently defined by <sys/types.h>
 as well, but we plan to remove this soon. To use "major", include
 <sys/sysmacros.h> directly. If you did not intend to use a system-defined
 macro "major", you should undefine it after including <sys/types.h>."

error. Since the normal Slurm build uses -Werror, this warning on including
both headers will then cause the build itself to fail.

Bug 3982.

Bug 4246

Bug 4246

Bug 4246

when a job spans a reservation that was modified (multiple records for
the same reservation).

Bug 4246

Bug 4246

Down waking nodes right after ResumeTimeout has been reached if they are
not responding. Otherwise we have to wait for ping_nodes() to handle
this work, thus SlurmdTimeout comes into play giving the sensation to
the end user that nodes got stuck in ALLOCATED# and job in CF state
until ping_nodes() decides to mark them DOWN and requeue the job.

Bug 4182

Update to commit 859f6c82

E.g., gpu:tesla:2 would have parsed as quantity "telsa" of gpu.
Change the index value to the end of the array (-1 index value).

Bug 4250.

Rather than end up with "%.-1s" printed out in the output as snprintf
refused to parse the format specifier.

Bug 4164.

bugzilla #4238 - Added a hint for the window manager to all popups and windows
in order to get max, min, close buttons in Gnome, XFCE, and others.

Bug 4244

Pending job with administrator extended TimeLimit beyond partition's
MaxTime remains pending with reason PartitionTimeLimit
bug 4262

The contoller will return node records with a NULL name for nodes that
are hidden. This is so that you can map a partition_info's nodes --
using it's node_inx[] -- to a node record in the returned node_array
from slurm_load_node().

Previously the perl api would leave an undefined object in the the
node_array if the hidden nodes were found before a real node in the
node_array and any hidden nodes at the end of the array from the
controller wouldn't be counted for in the perl node_array. This patch
adds empty hashes for hidden nodes and preserves the record_count and
node_array from the slurmctld.

Bug 4250

The perl api leaves undefined objects in the node_array returned by
load_nodes() for any node that is hidden.

But 4250

Bug 4003

as process exits

Bug 4003

when using xstrcasecmp. Matching up with other xstrcmp() functions.

was missing

Bug 4226

that there was no bit_fmt was out of scope on the xfree. Passing
a function address to xfree() predictably does not work very well.

Change the variable name to avoid confusion.

Bug 4241

Before:
$ sbatch --wrap="sleep 300"
Submitted batch job 228
$ squeue
             JOBID PARTITION     NAME     USER ST       TIME   CPUS NODELIST(REASON)
               228     debug     wrap    brian PD       0:00      1 (AssocMaxUnknownPerNode)

Fixed:
$ squeue
             JOBID PARTITION     NAME     USER ST       TIME   CPUS NODELIST(REASON)
               229     debug     wrap    brian PD       0:00      1 (AssocMaxCpuPerNode)

$ sacctmgr mod account stuff set maxtrespernode=cpu=-1,mem=1
$ squeue
             JOBID PARTITION     NAME     USER ST       TIME   CPUS NODELIST(REASON)
               229     debug     wrap    brian PD       0:00      1 (AssocMaxMemPerNode)

$ sbatch --wrap="sleep 300" --gres=blah:2 -pgpu
Submitted batch job 235
$ squeue
             JOBID PARTITION     NAME     USER ST       TIME   CPUS NODELIST(REASON)
               235       gpu     wrap    brian PD       0:00      1 (AssocMaxGRESPerNode)

burst_buffer/cray plugin modified to work with changes in Cray UP06
   software release.
Specific changes: Cray software now returns an error if a state_in
   or stage_out script is processed that doesn't actually request a
   stage in or out (previously silently ignored).
Also the warning message about tearing down a buffer that is already
   gone changed.

Move the check up a bit more where it'll do some good.

Bug 4184.

Bug 4146.

Bug 3467

Bug 3567

gres listed in your slurm.conf but some in gres.conf.

Bug 3974

'type' but no file defined.

plugin when constraining devices.

correctly in sacct.

A second PMI2_Init() within the same step is invalid, and cannot succeed.

Return an error code back to the client end, and close the fd to force the
step to terminate immediately.

Due to a bug in our libpmi code, just returning a cmd=response_to_init with
an appropriate rc number will not tear down the connection properly, so
send back something else that will trigger the error path.

Bug 3520.

Bug 4154.