Unused by launch/slurm.

Only works with non-launch/slurm plugins.

There is only launch/slurm currently.

Hasn't been documented since at least version 2.6, and does nothing.

Changed to the documented form before 17.11 was released.

Return an xmalloc()'d string. Clean up string handling to
use xstrfmtcat / xstrcat / snprintf instead of sprintf.

Use that new function in a minimal new cpu_freq_set_env().

Coverity CID 45165

No new functionality, just for clarity and consistency.

Bug 6681

Bug 6681

Broken in commit 9118a41e

Broken in commit 9118a41e

Can now only be used to launch steps in an existing job allocation;
it can no longer be used by SlurmUser to create a new job allocation
with a given jobid value.

Bug 6691.

Bug 6691.

If running within salloc or a job step, both SLURM_JOB_ID and SLURM_JOBID
would be set to the same value, and SLURM_JOB_ID would overwrite SLURM_JOBID
as it is parsed second.

The only time this would cause a difference in behavior is if SLURM_JOBID
were set, and SLURM_JOB_ID were not. Which is not something that can be
caused by Slurm itself.

This configuration previously caused test15.10 to fail
(but only when run as part of full regression test due
to NHC running on previous jobs).

Non-operators are not permitted to submit jobs with a negative
nice value. Rather than silently reset the value, reject it outright.

Without moving the function, it is undefined when referenced

Bug 6286

This reverts commit 082c59dd.

Bug 6286

Continuation of 6fc7298f

Bug 6286

The key and keylen are already cached inside uthash's
UT_hash_handle. So the memory is wasted.
Bug 6620

Hash functions no longer take the bucket as parameter.
Use of the HASH_FCN can be changed, since the
1,000,000 parameters is not needed. The hash is used for
comparison.
Bug 6620

Under some conditions the requested 4 tasks could not land 2 per
node. This change explicitly sets --ntasks-per-node=2 so it should
always work.

This fixes 24c04bce. Related commit c8c9694f.

Bug 3808
Bug 6681