Coverity CID 166002

Coverity CID 174399

Fix typo
Coverity CID 174400

bug 3217

Coverity CID 44815

If srun lacks application specification for some component, the next one
      specified will be used for earlier components.

This insures that the batch script can have appropriate environment
  variables set for all components (i.e. the node list, cpu count,
  etc. for all pack groups).

Previous logic was not properly setting env vars for pack jobs. In
  some cases the env vars were being set in slurmctld and NOT only
  if the parameter was set on sbatch command line.

When the "scontrol update jobid=#" command specifies a pack job
leader, then modify all components of the pack job. To modiify only
the pack job leader, specify "scontrol update jobid=#+0".

This reverts commit 00a691b9.

Modify scontrol job hold/release and update to operate with heterogeneous
      job id specification (e.g. "scontrol hold 123+4").

Fix sview to avoid messages to stderr when modifying a block, partition,
    or reservation.
bug 3217

This will allow dell's custom syscfg to work correctly.

NOTE: Dell calls flat memory just memory.

Bug 4034

If scancel is called only with job filter options (e.g. --user=..)
  and that results in an attempt to cancel a pending pack job component
  then do not log the ESLURM_NOT_PACK_WHOLE error code.

No code change, just moving existing code into a switch ready to handle
multiple options.

Bug 4034

Add SystemType to knl_generic.conf for knl_generic in preparations for making KNL work on a Dell system.

Add SystemType to knl_generic.conf.  This is used to distinguish
differences in vendors such as 'Dell'.

    Bug 4034

Prior logic would report "No error" rather than "already complete"

Doing so would break the current scheduling logic.

Bug 4059

Coverity CID 44817

Coverity CID 44731

Coverity CID 45279, 44884