Bug 4747.

Fixes some issues around differences in lua package naming.

Bug 4568.

Bug 4709.

Previously it was taking the MIN, without respecting the order.

Also add a note to the resource_limits.html page to clarify the
exception for Max[Wall|Time] and/or [Max|Min]Nodes limits, where
the default is that the Partition is the king with regards of
precedence, unless the respective job's QOS flags
Partition[Min|Max|Time]Limit are set.

Bug 4681.

This prevents a hard-to-diagnose issue where slurmstepd may fail
to start due to a missing library. This now ensures slurmd will
fail, and keep the node down until the library issue can be fixed.

Bug 4645, 4644.

fatal() calls exit(1) which precludes getting a backtrace.
That's fine on configuration issues and other types of problem,
but for hitting "impossible" edge cases getting a core dump may
be the only way to isolate the issue.

Adding to 17.11 so we can easily provide diagnostic patches without
needing users to back-port this implementation. Further use will
come in 18.08.

Bug 4599.

This reverts commit 18b35709.

This reverts commit 6a91845b.

Wait for the prolog to complete, and then clean up after it.
Otherwise orphaned "sleep" executables will be created by the
still-launching step_extern.

Bug 4718.

Preserve node features when slurmctld daemons reconfigured including
active and available KNL features.
bug 4734

Bug 4630.

Bug 4722

keyvalue_initialized is reset on 'scontrol reconfigure' and other
cases, which can lead to additional atfork handlers being registered.

These can eventually lead to a segfault if an excessive number of
handlers have been re-registered. Set a separate boolean to protect
against this. Clear that boolean as part of the atfork handler.

Bug 4628.

UsePss was correct, but UsePSS and usepss would be silently ignored,
leading to confusion as to whether the option was working or not.

Treat all JobAcctGatherParams as case-insensitive to avoid confusion.

Bug 4637.

This reverts commit 516b0d59.

With the fixing of the NEWS file.
We want to keep the idea of only checking one federation.

Bug 4548

This reverts commit fb73b8a4.

# Conflicts:
#	NEWS

message before purging the job record to get the uid of the revoked job.

Bug 4502

This reverts commit fc0c3e6c.

message before purging the job record to get the uid of the revoked job.

Bug 4502

Bug 4651

Bug 4548

Bug 4634

job container where if the step was canceled would also cancel the stepd
erroneously.

Bug 4634

one already exists owned by a different user will be logged and the job
held.

Bug 4614

Bug 4681

from when last started.

Signed-off-by: Danny Auble <da@schedmd.com>

if LaunchParameter test_exec is set.

Bug 4439

rights by a secondary group id.

Bug 4439

introduced in commit ea85d123

Bug 4613

Commit 818a09e8 introduced a new state JOB_OOM and a new state reason
FAIL_OOM (OutOfMemory). The problem was that it based the decision upon
the value of the different memory.[*].failcnt being > 0.

That lead to "false positives" situations when the usage hit the limit
but the Kernel was able to reclaim pages and the process managed to finish
successfully. When this happens there might not necessary be OOM_KILL
events happening.

This patch makes it so the JOB_OOM state is set based upon OOM_KILL events
detected instead of usage hitting the limit. The usage hit will still
be logged as an info() message, and further work will be needed in the
master branch to better discern both type of events, maybe changing
the API and getting rid of the current SIG_OOM and a potential new
SIG_OOM_KILL.

OOM_KILL event is detected using the eventfd notification mechanism
on the cgroup v1 control/event files:
https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt

If we plan to support cgroup v2, we should monitor 'memory.events' file
modified events. That would mean that any of the available entries changed
its value upon notification.
Entries include: low, high, max, oom, oom_kill:
https://www.kernel.org/doc/Documentation/cgroup-v2.txt
https://patchwork.kernel.org/patch/9737381
but since this is a fairly recent change many sites might be running
kernels still not supporting this feature.

Bug 3820.

This reverts commit d3141dc9.

Bug 4655

Turns out there are many ways to get this information directly from
the slurmstepd.  As you can already get this information from ps we
decided to just revert back to the old non-authenticated way of doing
things.

If we do need this in the future we need to patch the stepd as well as
the slurmd here in all the RPC's that try to grab this.

A user could easily run scontrol (or their own home baked thing)
on the node which will give them a direct contact with the slurmstepd.

This reverts commit c4fb9bc3.

This reverts commit d3141dc9.

Bug 4655

Turns out there are many ways to get this information directly from
the slurmstepd.  As you can already get this information from ps we
decided to just revert back to the old non-authenticated way of doing
things.

If we do need this in the future we need to patch the stepd as well as
the slurmd here in all the RPC's that try to grab this.

A user could easily run scontrol (or their own home baked thing)
on the node which will give them a direct contact with the slurmstepd.