- 21 Dec, 2011 2 commits
-
-
Morris Jette authored
-
Morris Jette authored
-
- 20 Dec, 2011 1 commit
-
-
Morris Jette authored
-
- 19 Dec, 2011 1 commit
-
-
Morris Jette authored
-
- 17 Dec, 2011 3 commits
-
-
Morris Jette authored
-
Mark A. Grondona authored
When importing an exported shell function, the bracket count code didn't handle negative return value from _bracket_cnt(), so a shell function (or a shell variable starting with '(') would loop until the end of the env output. Since the test for no open bracket wasn't handled anyway, remove this and clean up _bracket_cnt() code (which now returns negative if there are more closing than opening brackets). Also, remove the unneded local integer bracket_cnt from the while loops and only continue processing while the bracket tally is > 0. Note: There are still many unhandled corner cases in this code.
-
Mark A. Grondona authored
src/common/env.c:env_array_user_default() tries to import a "default" user environment by parsing the output of something like su - <user> -c "/bin/env" ( or "slurmstepd getenv") (or an equivalent) when the job is run with --get-user-env. There is some code that tries to detect and import exported bash shell functions, which usually have the form func=() { ... } into the job environment. However, one of the many problems with the code is that the test for bounds overflow: if ((strlen(value) + strlen(line)) > (sizeof(value) - 1)) break; useis sizeof(value) and value is a char *. This means that all multiline shell functions are truncated, and the following error appears in users batch script output: /bin/sh: func: line 1: syntax error: unexpected end of file /bin/sh: error importing function definition for `func' This patch fixes the bounds test. Similar cut-and-paste code in _load_env_cache() was also fixed. However, it should be noted that there are many other potential cases where shell functions will not be properly imported by this code. (For example, quoted unbalanced brackets used in the function) Someday this should be fixed.
-
- 15 Dec, 2011 1 commit
-
-
Morris Jette authored
Prevent resetting a held job's priority when updating other job parameters. Patch from Alejandro Lucero Palau, BSC.
-
- 14 Dec, 2011 4 commits
-
-
Morris Jette authored
Patch from John Thiltges, University of Nebraska-Lincoln.
-
Danny Auble authored
-
Danny Auble authored
-
Danny Auble authored
-
- 09 Dec, 2011 6 commits
-
-
Danny Auble authored
-
Danny Auble authored
starts in accounting.
-
Danny Auble authored
-
Morris Jette authored
-
Morris Jette authored
There was an oversight in the GracTime preemption logic that resulted in repeatedly reading the PreemptType configuration parameter and doing a string comparison. This change will improve efficiency of that logic.
-
Morris Jette authored
-
- 08 Dec, 2011 2 commits
-
-
Danny Auble authored
-
Danny Auble authored
-
- 06 Dec, 2011 2 commits
-
-
Morris Jette authored
One of our testers discovered a regression in version 2.3.1. If a job is pending due to PartitionNodeLimit and the limit is relieved with a 'sacctmgr modify qos name=<qos name> set flags=partitionmaxnodes' new jobs exceeding the partition limit (but not the QOS limit) are allowed to run. However, the pending job is never allowed to run. Attached is a patch to address this problem. FYI, this problem doesn't exist in version 2.4. Patch from Bill Brophy, Bull.
-
Yuri D'Elia authored
-
- 05 Dec, 2011 3 commits
-
-
Morris Jette authored
Patch by Alexander Bersenev (Institute of Mathematics and Mechanics, Russia).
-
Morris Jette authored
-
Morris Jette authored
-
- 02 Dec, 2011 2 commits
-
-
Danny Auble authored
There was also some bad code that would reset the conn_type of a block to SMALL no matter what type of SMALL it was.
-
Morris Jette authored
Patsh from Rod Schulz, Bull.
-
- 01 Dec, 2011 1 commit
-
-
jette authored
This was due to a bug in select/cons_res with some configuration optiions and job options, especially if there is more than one thread per core and the job option includes "--threads-per-core=1". Fixes problem reported by CSCS.
-
- 30 Nov, 2011 3 commits
-
-
Danny Auble authored
lock was deemed not necessary because the information (db_index) was only internal and was only modified in the same function later which is protected by the write lock.
-
Danny Auble authored
qos on the cluster to fill that in correctly.
-
Danny Auble authored
incorrectly when getting fairshare from the parent.
-
- 23 Nov, 2011 2 commits
-
-
Morris Jette authored
-
Danny Auble authored
wasn't started at the time the eligible message was sent but started before the db_index was returned information like start time would be lost.
-
- 22 Nov, 2011 2 commits
-
-
Morris Jette authored
-
Morris Jette authored
-
- 21 Nov, 2011 4 commits
-
-
Morris Jette authored
-
Morris Jette authored
-
Morris Jette authored
-
Morris Jette authored
Fix Lua link order
-
- 18 Nov, 2011 1 commit
-
-
jette authored
Patch from Yuri D'Ella
-