Coverity 178912

Coverity CID 178913

Removed references to versions <=16.05 and adapted to new 17.11

launch/slurm plugin - Avoid using global variable for heterogeneous job
    steps, which could corrupt memory.
bug 4333

Ancient versions of OpenMPI and their derivatives (i.e. Cray MPI) are
dependent upon communication ports being assigned to them by Slurm. Such MPI
jobs will experience step launch failure if any component of a
heterogeneous job step is unable to acquire the allocated ports.
Non-heterogeneous job steps will retry step launch using a new set of
communication ports (no change in Slurm behavior).

NOTE: Correcting this would necessitate assigning the same set of ports
to all components of the heterogeneous job (not possible today) plus changes to
srun in order to better synchronize the step startup and error handling.

Same logic as done in commit fb296c70 done for energy.

Bug 4336

If heterogeneous job step is unable to acquire MPI reserved ports then
    avoid referencing NULL pointer.
bug 4333

Force tres change on a job to send data to the database.

This should be happening already, but this just makes it always happen.

This fixes the possibility of going into this loop when we hadn't
setup the tres_req_cnt.  The simple case Coverity reported is if the
job is already finished it goes here and we never set up tres_req_cnt.

Coverity CID 178897

This fixes the possibility of referencing a NULL pointer if the
reservation doesn't exist anymore when testing.

Coverity CID 178898

Bug 3647.

Bug 4353.

Also collapse a nested %{with cray} block leftover from earlier work.

Bug 4332.

Logic was inverted from the correct behavior.

Bug 4332.

Slurm package should not try to manage configs; leave this to the
admin to setup as they wish. This avoids an issue on RPM install if
/etc/slurm is a symlink to somewhere else.

Bug 4332.

Bug 4332.

Bug 4332.

(uint32_t)IFINITE

Threw away NO_VAL conflicts will handle in subsequent commits.

%{_libdir} is /usr/lib64. Adding this can cause ordering
problems with the library search path, and is redundant.

And %{_libdir}/slurm is not needed by Slurm itself; it relies on
rpath to resolve the install location instead.

So, this is only useful on a non-standard install, in which case
it's best left to the site to decide how to handle this instead.

Bug 4344.

as to why SLURM_MPI_TYPE is uninitialized in a step.

Bug 4141