Fix regression caused by commit bb8b4214.

Commit bb8b4214 introduced this in scontrol_hold():

-		job_msg.job_id_str = _next_job_id();
-		while (job_msg.job_id_str) {
+		while ((job_msg.job_id_str = _next_job_id())) {

But didn't take out _next_job_id() at the bottom of the while loop -
so _next_job_id() is called twice in a row, skipping every other job
in the list.

Bug 5902

rpaths, for RHEL based distros which use "check-rpaths" tool.

Bug 5780

Bug 5603

Bug 5603

a job is preempted.

Bug 5460

... due to a failure from DataWarp.

Bug 5800.

Regression caused in 18.08.1; can happen under any circumstance that
leads to the job array elements being split before the backfill/sched
has had a chance to populate these.

Bug 5876.

up when the dbd was down.

This reverts commit c07784b4.

Bug 5875 and 5613

Alongside previous commit, fixes errors like:

error: acct_policy_handle_accrue_time: QOS normal accrue_cnt underflow

Bug 5863.

Would have been incorrectly set to 0 if begin_time hadn't been
established yet.

Bug 5863.

a jobs --mem-per-cpu and also -c is greater than 1.

Bug 5858

PreserveCaseUser.

Bug 5813

Bug 5813

curr_inx needs to be reset correctly on each line. Overlooked
in commit cbc0b901 when that was moved to a global variable.

Bug 5831.

/proc/sys/kernel/pid_max.

Bug 5697

scheduled right away.

Bug 5774

Basically this reverts ec59bb1b which appears to be an academic
performance patch.  When testing a bitmap of 10000 with every other
bit set it only took at most 4 usec with most taking 1 usec.

of an array.

Bug 5794

so that jobs can be submitted and queued when requesting more licenses
than are configured. This is helpful when using licenses to control
access to file systems.

Bug 5630

Signed-off-by: Danny Auble <da@schedmd.com>

so that a job's license string can be updated after a restart with licenses
removed or added.

Bug 5630

If a job requested multiple licenses and one license was removed then on
a reconfigure/restart all of the licenses -- including the valid ones
would be removed.

Bug 5630

when configured license counts are 0.

Bug 5630

Bug 5680

determine the time a node has been down.

This prevents from the wrongly set node as DOWN, if we decrease
SlurmdTimeout and agents queue is busy.

Bug 5811

it is reconfigured to determine changes in its background timers.

Bug 5811

reached in the cons_res plugin.

Bug 5328

structures after unpack.

Bug 5821

Bug 5815

Also simplify this xstrfmtcat() into an xstrcat() call while here.

Bug 5828.

Leads to false-positive warnings about settings being too low when
they're actually fine. E.g., if innodb_buffer_pool_size is over 2GB
the warning would have been printed in error.

Bug 5661.

Bug 5594.

You should not make RPC calls within MailProg (or anything else
fork()+exec()'d from slurmctld), so use the environment variable that
is now exposed instead.

Bug 5443.

smail currently uses 'scontrol show config' to get this data; making RPC
calls within programs fork()+exec()'d from slurmctld is best avoided as
it amplifies RPC load on the controller.

Bug 5443.