No other options use underscores, so make these consistent with
the rest. Both old and new syntax is supported for now.

Change all 'verbose' option output to use dashes, and adjust
the testsuite to match.

Fix a few related documentation errors while here.

Turns out what was there before was completely incorrect.

Bug 4246

If configured with NodeFeatures=knl_cray and there are non-KNL
  nodes which include no features the slurmctld will abort without
  this patch when attemping xstrdup(NULL).
bug 4294

the same id.

There is no /slurm page, this was missed in the new style conversion.

Display the commands that are being exec'd

nodes and didn't specify the cluster.  This shouldn't matter for sacctmgr after
the last commit.

with sacctmgr.

reservations instead of adding them which will create a new record in the
database with correct node indexes.

end_time second in the query, it will be the same as the start time of the
next cluster in the list.

We only need to fill in the end time for the 'slurmctld disconnect' if
nothing has changed.  Otherwise the very next update will do it for everything.

This hasn't been needed for a while and is now handled
in the other 'ifs' above it.

ACCOUNTING_TRES_CHANGE_DB.

In a future commit we will code what to do with these in the slurmctld.

This will be used to tell if we are 17.02 or less when sending in the TRES.

We need this to determine if we can return new rc codes.  This can be reverted
if so desired in 18.08.

Bug 4279

(-O1 makes this happen).

This should be handled differently in the future meaning Slurm should figure
out the null part and not rely on *printf to do that correctly.

Bug 4062

Before it would allow all sorts of things like
adding/subtracting/multiplying/etc.  It would cause warnings such as

/home/bart/slurm-tmp5/src/common/layouts_mgr.c: In function ‘_layouts_load_automerge’:
/home/bart/slurm-tmp5/src/common/layouts_mgr.c:363:21: error: ‘*’ in boolean context, suggest ‘&&’ instead [-Werror=int-in-bool-context]
   *lvalue = *lvalue * *rvalue;     \
             ~~~~~~~~^~~~
/home/bart/slurm-tmp5/src/common/layouts_mgr.c:1034:4: note: in expansion of macro ‘_entity_update_kv_helper’
    _entity_update_kv_helper(type_t, operator); \
    ^~~~~~~~~~~~~~~~~~~~~~~~
/home/bart/slurm-tmp5/src/common/layouts_mgr.c:1086:4: note: in expansion of macro ‘_layouts_load_merge’
    _layouts_load_merge(bool, s_p_get_boolean);
[tag] [reply] [−] Private Comment 16

Bug 4062

Setting -Werror tricks the test into failing on the

"error: In the GNU C Library, "major" is defined by <sys/sysmacros.h>.
 For historical compatibility, it is  currently defined by <sys/types.h>
 as well, but we plan to remove this soon. To use "major", include
 <sys/sysmacros.h> directly. If you did not intend to use a system-defined
 macro "major", you should undefine it after including <sys/types.h>."

error. Since the normal Slurm build uses -Werror, this warning on including
both headers will then cause the build itself to fail.

Bug 3982.

This was not needed when ecd5c056 was done.  The other 2 places in that
commit were correct.