- Move var declarations to beginning.
- Add some goto cleanup* statements.

Bug 2693.

==6281== 36 bytes in 2 blocks are definitely lost in loss record 123 of 292
==6281==    at 0x4C2FB45: calloc
(in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==6281==    by 0x502B72F: slurm_xmalloc (xmalloc.c:84)
==6281==    by 0x502CA2A: xstrdup (xstring.c:350)
==6281==    by 0x7F9552C: ???
==6281==    by 0x4F3419D: acct_gather_profile_g_create_dataset
(slurm_acct_gather_profile.c:648)
...
==6281== 160 bytes in 2 blocks are definitely lost in loss record 234 of 292
==6281==    at 0x4C2FD4F: realloc
(in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==6281==    by 0x502B8AB: slurm_xrealloc (xmalloc.c:143)
==6281==    by 0x7F955C8: ???
==6281==    by 0x4F3419D: acct_gather_profile_g_create_dataset
(slurm_acct_gather_profile.c:648)
...
==6281== 552 (160 direct, 392 indirect) bytes in 2 blocks are definitely
lost in loss record 257 of 292
==6281==    at 0x4C2FD4F: realloc
(in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==6281==    by 0x502B8AB: slurm_xrealloc (xmalloc.c:143)
==6281==    by 0x7F95581: ???
==6281==    by 0x4F3419D: acct_gather_profile_g_create_dataset
(slurm_acct_gather_profile.c:648)

Bug 2693.

This option will define the database retention policy that should be
used when writing data to influxdb.

Bug 2693.

Previously the function was called just once at init() and stored. Since
value can be changed dynamically with 'scontrol setdebugflags' then we
should not reuse the initial value.

Bug 2693.

Bug 2693.

Original source:
https://github.com/cfenoy/influxdb-slurm-monitoring

Report NodeFeatures plugin configuration with scontrol and sview commands.
bug 4036

Coverity 182192

Bug 4621

when using multi-prog option.

Bug 4621

Bug 4621

Test 3.11, file inc3.11.9 only runs for some configurations, but
  assumes no leading zeros in node name suffix. When run with
  nodes named "nid[00001-00005]", the test converted the last
  number to it's numeric for and as making requests for
  "nid[00001-5]", which would fail.

Fix output file containing "%t" (task ID) for heterogeneous job step to
    be based upon global task ID rather than task ID for that component
    of the heterogeneous job step.

This expands some comments
Explicitly sets some pointers to NULL after memcpy (these are
   redundant, but add clarity) and
Move a memcpy to avoid modifying the wrong values

Fix for possible memory corruption in srun when running heterogeneous
job steps.
bug 4626

This should never happen in practice
Coverity CID 181927

Coverity CID 181959

Coverity CID 181960

This partially reverts 89bcd975 and aac6bd39

Turns out you can't use a list_for_each and lock something inside the
list_for_each function that does a lock without the write lock.

Bug 4611

This reverts commit ff3e77f4.

This partially reverts 89bcd975 and aac6bd39

Turns out you can't use a list_for_each and lock something inside the
list_for_each function that does a lock without the write lock.

Bug 4611

Otherwise undocumented, and does not do anything.
Will be removed in 18.08.

This should never happen with a valid feature specificiaton
Coverity CID 181927

This should not happen with a valid feature expression, but this
  change hardens the code
Coverity CID 181926

Coverity CID 181925

Coverity CID 181924

in the current directory but not in the --chdir specified cwd.

Now srun looks for the command in specified cwd and differentiates all
the possible cases where a command starts with ./ (relative), with /
(absolute), and with a different char indicating a command that is in
the path.

Fix also for a PATH variable starting by '.', now it is relative to
specified cwd.

bug 4392