Previous logic was failing if no specialized cores configured on node
  and job wanted to configure some
bug 3349

Null terminate before strchr().

This is a new message when "PrologFlags=contain" or
  "PrologFlags=alloc" is configured.
bug 3351

Cancel interactive job if Prolog failure with "PrologFlags=contain"
    configured.
bug 3351

Minor fix to commit 1e6b7522 in
  the case where user specification of specialized cores is disabled.
bug 3349

If a job specifies --core-spec and the node has identified specialized
  cores using the CpuSpecList option which are not the default cores
  (e.g. the first cores rather than the last cores on each socket),
  the the user's cores will be selected from those identified in the
  configuration.
bug 3349

This requires dealing directly with the running cluster and mucking
with it's database.

(user, account, cluster)

old sql method archive.

Was printing int64 using %ld, which generated a warning on some systems

Missed during memory conversion from 32 to 64bit. Found by clang/asan.

Only used by _gids_hashtbl_idx(); replace the string hash function
with a loop based off _get_hash_idx in slurmctld instead.

Does not appear to have ever been used.

This reverts commit 5a4b9e0c.

Options to include based on hostname or IP address were #if 0'd
by 4187ecb5.

Clean up function definition blocks while here.

Was used for authd, but not for auth/munge or auth/none.

Don't alloc select_jobinfo and put it on the job_desc that is being
packed. If the job_desc is being packed simultaneously by mutliple
threads then problems can happen if the ptr is changing mid-flight.
So create and pack a local select_jobinfo.

Do not allocate specialized cores to jobs using the --exclusive option.
bug 3349

Fix several memory leaks and file descriptor leaks in slurmstepd.
Prolems reported by Coverity.

Bug introduced in commit 0d4773a9

Fix 2 memory leaks
Fix 1 file descriptor leak
Fix 2 buffer overflow problems
All problems reported by Coverity

This bug, reported by Coverity, could result in memory corruption

Fix 3 possible memory leaks
Fix 1 possibly unterminated string
Prolems reported by Coverity

This isn't a real problem as the process does an exec right afterwards,
  but this change should make a Coverity error go away.

Two memory leaks
Invalid pointer use (function returning integer rather than pointer)
Out of bounds memory reference
Problems reported by Coverity

Reported by Coverity

Problem reported by Coverity, "description" never set, but tested
  and xfreed.