When specifying -j and not -s then non-eligible jobs will be shown
by sacct.
Time windows can also be used with -S and -E.
If --state is also used then non-eligible jobs won't be shown,
because non-eligible are not actually PD.

Bug 6873

# Conflicts:
#	NEWS

Bug 6805

Bug 6898

Continuation of commit cc153e03

Cancelled jobs before start have time_start=0 in the DB, but their
time_end!=0 (the cancel time).
Query fixed to handle properly these cases for -s PD.

Bug 6894

Bug 6878

Test was always leaving around a file named "slurm.conf.orig".
Now delete the file on test success.

bug 6878

Bug 6878

Brought the option in line with the "numtasks" option you use when
not specifying --step. Preserved backwards compatbility for "numtask"
for steps. Also upated docs and expect test.

Bug 6861

Properly initialize structures throughout Slurm.

Bug 6613

Bug 6613

Bug 6613

Regression from aca37654

.

Bug 6826.

Co-authored-by: Chad Vizino <chad@schedmd.com>

Wrong variable was used.  This works fine for 18.08, but in 19.05 this
code doesn't work correctly.

Bug 6739

Bug 6865

Bug 6313

Bug 6625.

These are conditions that need to remain constant until something
changes on the job to reevaluate.

Bug 6625

What was happening here is you had to not be >= operator to have the old
limits removed.  This makes it so it always happens.

Bug 6625

Bug 6625

Before we went up the tree to the next assoc_ptr.  As we validate an
association on the id as well as the uid the assoc_ptr was eventually
going to become invalid.  Setting it to NULL here solves a bunch of
issues with things later on.

Bug 6625

Bug 6625

Bug 6625.

Don't abort when the job doesn't have an association that was removed before the job was able to make it to the database.

Bug 6625

Bug 6625

The backfill scheduler keeps a local list of job pointers. Since the
backfill scheduler yields locks, it's possible for pending jobs to be
canceled and purged in these yield periods. The backfill scheduler then
has pointers to now invalid memory, and dereferencing those pointers is
undefined behavior and may result in a segfault.

This commit prevents purging jobs while the backfill scheduler is
running.

Bug 6621

The next patch will use slurmctld_diag_stats.bf_active to determine
if we can purge jobs or not.

Bug 6621

Bug 6739

Bug 6785.

Update slurm.spec and slurm.spec-legacy as well.

Bug 6608.

Bug 6807.

==8640== Thread 5 bckfl:
==8640== Syscall param openat(filename) points to unaddressable byte(s)
==8640==    at 0x4A81D0E: open (open64.c:48)
==8640==    by 0x5934ABB: _update_job_env (burst_buffer_cray.c:3338)
==8640==    by 0x5934ABB: bb_p_job_begin (burst_buffer_cray.c:3962)
...
==8640==  Address 0x6b96120 is 16 bytes inside a block of size 61 free'd
==8640==    at 0x48369AB: free (vg_replace_malloc.c:530)
==8640==    by 0x49D4873: slurm_xfree (xmalloc.c:244)
==8640==    by 0x490C317: free_command_argv (run_command.c:249)
==8640==    by 0x5934A5C: bb_p_job_begin (burst_buffer_cray.c:3947)
...
==8640==  Block was alloc'd at
==8640==    at 0x4837B65: calloc (vg_replace_malloc.c:752)
==8640==    by 0x49D4566: slurm_xmalloc (xmalloc.c:87)
==8640==    by 0x49D4B67: makespace (xstring.c:103)
==8640==    by 0x49D4C91: _xstrcat (xstring.c:134)
==8640==    by 0x49D4ECF: _xstrfmtcat (xstring.c:280)
==8640==    by 0x593497C: bb_p_job_begin (burst_buffer_cray.c:3936)
...

Bug 6807.

Bug 6807.