By removing the real locks we can get into a race condition where the prolog
starts and finishes before we get here and then we end up waiting forever.

Making the mutex a static seemed to help in many cases, but didn't
completely close the window.  Changing slurm_cond_wait to
slurm_cond_timedwait fixed the scenario where we would hit the window, but
not degrade performance the original commit provides.

There were also spots where if the job or step didn't exist it wouldn't
signal the conditional also providing a spot this could get stuck not
starting the job.

Fix regression from commit 52ce3ff0

Bug 3977

Code provided by Ole Nielsen <Ole.H.Nielsen@fysik.dtu.dk>

Bug 3985

This is a regression from commit fec995e0.

It turns out using tok here was erroneous for situations where the gres had
a type and name and potentially a count (i.e. network:gigabit:1)

_get_gres_req_cnt() would alter the incoming char *config which is what tok
was.  So when we print it back to the requested string it would only have
what was there to the first ':'.  As we didn't need to \0 out the first char
as we skip over it anyway I just kept track of what the replaced \0 was for
the number portion and put it back when we are done copying it.

Related to bug 3521

bug 3979

Bug 3967

Bug 3979 and 3989

This reverts commit d49081df.

Bug 3979 and 3989

will have a time displayed when truncating time.

Bug 3940.

Otherwise we can end up printing Start times greater than End times,
leading to confusion when reading sacct output. 0 is displayed as Unknown.
Cosmetic change.

Bug 3940.

This behavior was introduced in bug 2504, commit 7fb0c981 and bug 2643
commit 988edf12 respectively.

The reasoning is that sysadmins who see nodes with Reason "Not Responding"
but they can manually ping/access the node end up confused. That reason
should only be set if the node is trully not responding, but not if the
HealthCheckProgram execution failed or returned non-zero exit code. For
that case, the program itself would take the appropiate actions, such
as draining the node and setting an appropiate Reason.

Bug 3931

Bug 3963.

Bug 3938.

Bug 3954.

Bug 3947.

_update_bb_resv() received a bb_spec whose units were originally always
interpreted as powers of 1024 (IEC). This change supports both IEC/SI
formats.

Bug 3922

Bug 3922

burst_buffer logic modified to support sizes in both SI and EIC size units
    (e.g. M/MiB for powers of 1024, MB for powers of 1000).
bug 3922

This patch removes a window in which a message bound for the DBD
could be packed with the non-dbd packing.  This would result in a
packed msg_type, but nothing else.  When that message was given to
the DBD it would complain forever about an unpacking error.

Bug 3891 and 3939

done.

Pretty much remove 10cc6f93

Bug 3919

workflows through the slurmd.

Bug 3833

from the slurmctld make sure the step allocation is made aware of it.

Bug 3926

Also see commit b30139e5

test1.91 fails with non-default binding

Bug 3581.

test 17.12 was leaving slurm-#.out files around. Explicitly set
  output file to /dev/null and set time limit to 1 minute to avoid
  vestigial jobs.