Turns out if you don't close up everything you open the hdf5 lib doesn't
like that.

Fixs regression in 011b2f23.

avoid copying strings that may be overwritten.

Bug 5547

It turns out it is fairly easy with het jobs to hit this and seg fault srun.

Bug 5390

Bug 5547.

Bug 5547.

Causes srun and sattach to fail on big endian platforms.

Bug 5556

Wrong author.

This reverts commit 392e7cfc.

a job with scontrol.

Bug 4964

not work when trying use sattach.

Bug 5556

to run the regression tests 24.* without changing that code since it links
directly to the priority plugin where that function isn't defined.

Bug 5558

Continuation of commit 21d2ab6e

Update slurm.spec and slurm.spec-legacy as well.

Fix NEWS header.

Fixes bad casting caused by Tim on review.

Make one definitive copy of sort_part_tier() in partition_msg.c and use it.

Bug 3844, 5552.

and other drain + node state flags.

Bug 5505

Update slurm.spec and slurm.spec-legacy as well.

Bug 5505

Bug 5164.

Without this patch the slurmctld would send a finishing message to srun
which may already be torn down.  This prevents printing a benign
error message.

Bug 3844.

Bug 5526

Bug 5526

Bug 5171

so that the tests won't fail due to trying to set time limits greater
than MaxTime.

Bug 5171

Bug 5171

in order to be able to set a partition's MaxTime

Bug 5171

To set a partition's MaxTime

Bug 5171

Bug 5528.

Only split nodes here if a node_features plugin is in use.

Otherwise node fragmentation will occur if the node config has
CPUs specified but not CoresPerSocket and Sockets.

This could be avoided by filling out the node definition, but
adding this workaround for backwards compatiblity.

Bug 5039.

Task prologs could set or modify this, so wait to create the
directory until after they've finished.

Bug 5367.

After changes to slurm_send_only_node_msg(), this message is much
more likely to appear on systems with overloaded interconnects since
that connection handling code may end up retransmitting messages
that were actually received (but that the transmit side could not
verify were delivered successfully).

As the error() message stated, this isn't actually an error, and
the code will proceed happily past this point. So drop the debug
level, and remove the surrealist "this is not an error" part.

Bug 5164.

There are subtle issues involved in treating a TCP transmission
as a unidirectional message delivery layer.

The original code path looks like: connect(), write(), close().
But Linux handles the write() and close() asynchronously behind the
scenes, and does not block until that write() has been ACK'd by the
remote end. So the write() and close() may succeed, even with data
still in flight. A communication error - and message loss - would
have been silently ignored, leading to unreliable message transmission.

Worse yet, one side of the connection would believe it sent the message,
while the receive side swears it never saw the packets. This leads to
infrequent and yet seemingly impossible data loss, and a very tough
bug to chase down.

This teardown code tries to force the connection to shut down in an
orderly manner, giving Slurm a chance to catch a connection problem
and the upstream calling path an opportunity to retransmit.

This teardown code is based on an approach described in Section 7.5
of "UNIX Network Programming" Volume 1 (Third Edition), specifically
the subsection regarding SO_LINGER. (And also covers why SO_LINGER is
not sufficent to prevent this issue.)

Bug 5164.

Bug 5164.

The getopt format string needs to handle an option here,
and the --help output had not been corrected after 99b2c4e8.

Bug 5522.

Bug 5070

Bug 5468

This is a backport of commit cefc9ec1.

scheduling cycle.  Primarily caused by EnforcePartLimits=ALL.

Bug 5452