This matches the functionality in code.

Bug 5726

Continuation of 06582da8 (17.11.9)

Poll was timing out too quickly due to an incorrect conversion of
MessageTimeout. Added a multiplier so timeout reflects the correct
millisecond value.

Bug 5553

Bug 5165

Bug 5231

Change slurmctld/controller.c's purge_thread_lock from static to
global extern, so the mutex can be used in slurmctld/job_mgr.c

slurm_cond_signal() needs to always be wrapped in the same mutex as
slurm_cond_[timed]wait(), or else there is a possibility that
slurm_cond_signal() will trigger before slurm_cond_[timed]wait()
is even listening, most likely causing a deadlock.

Bug 5703

initialize old fairshare association pointer correctly.

Bug 5744

Bug 5458

Bug 5748

Bug 5775

Bug 5613

bug 5669

The backup slurmctld can end up without an agent thread if
read_slurm_conf() takes too long to complete. Forcing the agent_init()
here again ensures it is restarted if not currently running.

This was fixed upstream in c1a537db.

Bug 5633.

is removed from the system.

Bug 5665

burst buffer.

Bug 5665

Bug 5359

Spaces need to be built into each key definition, otherwise it'll
all run together.

Bug 5657.

%n or %h in the spool dir.

Bug 5096

Fail early when the layout requirements cannot be satisfied in
_task_layout_lllp_block().

Otherwise step layout calculations will fail, leading to a
"fatal: _task_layout_lllp_block infinite loop"

Bug 5415.

The conditional for handling --overcommit was not sufficient to prevent
other option combinations from using that code path, resulting in
unexpected resource allocation behavior. Correct that to check that
overcommit is enabled.

Bug 5345.

Bug 5379.

running.

Bug 5624

for an allocation.

Bug 5293

Backport of 9a507584 in 18.08.

Bug 5608

Tim approved

If the dbd comes up after a job array has been submitted to the
controller, the controller calls _update_job_tres() which calls
assoc_mgr_set_tres_cnt_array() which allocates memory for the job's
tres_alloc_cnt. The job array gets scheduled, but job_array_split()
doesn't NULL out the pending job's tres_alloc_cnt, so both the array
task and the pending array job are pointing to the same memory. The
array task calls job_set_alloc_tres() which free's the running job's
tres_alloc_cnt and now the pending array job is pointing to bad memory
and when the array splits again the new array task tries to free
tres_alloc_cnt in job_set_alloc_tres() and segfaults.

Bug 5604

Bug 5561.

Bug 5072

Change _build_path to return the xmalloc()'d string, and make sure
to free it where appropriate.

Add comment about how the processing of the PATH environment variable
here is backwards from convention.

Fixes GCC 8.2.0 warnings.

Fix some -Werror=restrict and -Werror=format= issues.

Silence GCC 8.2.0 warning.

Nothing modifies this, so don't bother making a copy of it.

Related to GCC 8.2.0 compilation fixes.

Fixes GCC 8.2.0 compilation warnings.

Bug 5465.