Based upon work by Nicolas Bigaouette

Based upon work by Nicolas Bigaouette

Conflicts:
	src/slurmctld/node_scheduler.c

Fix bug when requeued batch job is scheduled to run on a different node
zero, but attemts job launch on old node zero causing fatal error
"Invalid host_index -1 for job #"

Avoid slurmctld abort due to bad pointer when setting an advanced
reservation MAINT flag if it contains no nodes (only licenses).

blocks are in an error state.

Hi,

With slurm 2.3.2 (or 2.3.3), I encounter the following error when
trying to launch as root a command attached to a running user's job
even if I use the --uid=<user> option :

sila@suse112:~> squeue
   JOBID PARTITION     NAME     USER    STATE      TIME TIMELIMIT
NODES   CPUS NODELIST(REASON)
     551     debug mysleep.     sila  RUNNING      0:02 UNLIMITED
1      1 n1

root@suse112:~ # srun --jobid=551 hostname
srun: error: Unable to create job step: Access/permission denied
<--normal behaviour

root@suse112:~ # srun --jobid=551 --uid=sila hostname
srun: error: Unable to create job step: Invalid user id <--problem

By increasing slurmctld verbosity, the log files displays the follwing
error :

slurmctld: debug2: Processing RPC: REQUEST_JOB_ALLOCATION_INFO_LITE from
uid=0
slurmctld: debug:  _slurm_rpc_job_alloc_info_lite JobId=551 NodeList=n1
usec=1442
slurmctld: debug2: Processing RPC: REQUEST_JOB_STEP_CREATE from uid=0
slurmctld: error: Security violation, JOB_STEP_CREATE RPC from uid=0 to
run as uid 1001

which occurs in function : _slurm_rpc_job_step_create
(src/slurmctld/proc_req.c)

Here's my patch to prevent the command from failing (but I'm not sure
that there is no side effects) :

to give a correct priority on the first decay cycle after a restart of the
slurmctld. Patch from Martin Perry, Bull.

Work by Nathan Yee, SchedMD

Fix typos, punctuation problems, gramar, formatting, etc.
Minor changes to content.

Note that accounting_storage/filetxt has limited data stored.
Remove reference to accounting_storage/gold