Move test ahead of possible dereference.

CID 177865.

Unused internally, but designed so a (future) cli_filter plugin
can send data in-band to a job_submit plugin.

Bug 3745.

This is no longer the case as of commit 224cd329 before 15.08
was released.

Bug 4228 / bug 1570.

as reported by CLANG

sent in here.

file.  It turns out the underlying code is all core based instead of cpu.

Specifying threads will result in unexpected behavior which can include
segfaulting the slurmctld.

name but different type.

successful one.

type.

plugin on stepd launch.

Not only that, but also make it so the slurmd sends this information over to
the stepd on init.

This also makes it so GRES of the same name and different types can happen.

Hopefully no functionality change.

by similar combining code from all the gres plugins.  Hopefully improving
maintenance.

into gres_plugin_state_file.  Hopefully no functionality change.

of 2 exactly same code paths, hopefully no functionality change.

Regular user use of "scontrol top" command is now diabled. Use the
   configuration parameter "SchedulerParameters=enable_user_top" to enable
   that functionality. The configuration parameter
   "SchedulerParameters=disable_user_top" will be silently ignored.
bug 3653

Bug 4220.

to account for changes made in 8014b5a4

Can set limits based off of TRESBillingWeights value.

Bug 4162.

Coverity CID 144120

Coverity CID 44803

Coverity CID 44813

Fix of 0ce35824

Before:
$ sbatch --wrap="sleep 300"
Submitted batch job 228
$ squeue
             JOBID PARTITION     NAME     USER ST       TIME   CPUS NODELIST(REASON)
               228     debug     wrap    brian PD       0:00      1 (AssocMaxUnknownPerNode)

Fixed:
$ squeue
             JOBID PARTITION     NAME     USER ST       TIME   CPUS NODELIST(REASON)
               229     debug     wrap    brian PD       0:00      1 (AssocMaxCpuPerNode)

$ sacctmgr mod account stuff set maxtrespernode=cpu=-1,mem=1
$ squeue
             JOBID PARTITION     NAME     USER ST       TIME   CPUS NODELIST(REASON)
               229     debug     wrap    brian PD       0:00      1 (AssocMaxMemPerNode)

$ sbatch --wrap="sleep 300" --gres=blah:2 -pgpu
Submitted batch job 235
$ squeue
             JOBID PARTITION     NAME     USER ST       TIME   CPUS NODELIST(REASON)
               235       gpu     wrap    brian PD       0:00      1 (AssocMaxGRESPerNode)