Cleanup other code around here as well, and replace msg_type
with msg->msg_type now that select/serial cannot swap that out.

Cleanup other src/slurmd locations as well.

Without select/serial, replace_batch_job() collapses to a call to
slurm_send_rc_msg(msg, SLURM_SUCCESS) and then returns false.

So just do that instead, and delete this entire function.

Bug 5713.

This is not recommended for use, and will be removed in 19.05.

Update slurm.spec and slurm.spec-legacy as well.

Update slurm.spec and slurm.spec-legacy as well.

Update slurm.spec and slurm.spec-legacy as well.

Alongside previous commit, fixes errors like:

error: acct_policy_handle_accrue_time: QOS normal accrue_cnt underflow

Bug 5863.

Would have been incorrectly set to 0 if begin_time hadn't been
established yet.

Bug 5863.

Pull out BlueGene specific pieces of etc/init.d that are no longer
relevant, and run autogen.sh to pick up the build system changes.

Bug 5880.

Correct spelling in symbol name

Pull out BlueGene specific pieces of etc/init.d that are no longer
relevant, and run autogen.sh to pick up the build system changes.

Bug 5880.

ESLURM_UNSUPPOERTED_GRES ==
Requested GRES option unsupported by configured SelectType plugin

We do not recommend use of any AuthType aside from MUNGE. (And the links
here were already invalid.)

Similarly, CryptoType (and associated JobCredentialPrivateKey and
JobCredentialPublicCertificate options) are not generally used,
and should only be set after further consultation with the docs.

The only other option for CheckpointType besides checkpoint/none is
blcr which is deprecated, so remove that and JobCheckpointDir as well
while here.

Bug 5870.

a jobs --mem-per-cpu and also -c is greater than 1.

Bug 5858

PreserveCaseUser.

Bug 5813

Bug 5813

Already removed from the code along with the rest of Cray/ALPS support.

CID 188791.

curr_inx needs to be reset correctly on each line. Overlooked
in commit cbc0b901 when that was moved to a global variable.

Bug 5831.

curr_inx needs to be reset correctly on each line. Overlooked
in commit cbc0b901 when that was moved to a global variable.

Bug 5831.