bug 3037

Conflicts:
	src/plugins/burst_buffer/common/burst_buffer_common.h

bug 3035 and 3009

This reverts commit 933d4fba.

Conflicts:
	src/plugins/select/cray/select_cray.c

Otherwise blade_cnt is potentially greater than
bit_size(jobinfo->blade_map) which leads to an assertion failure.

Bug 3033.

instead of 2+. Continuation of previous commit.

with hwloc.

This patch has two parts:
1. When a job is intially submitted, the Slurm was failing to set
   an initial reason for the job not starting.
2. After a job was submitted, it was sometimes failing to reset
   the job's reason. It was also failing to reset the "last_job_update"
   time, so something like "squeue -i1" would not get the new reason.
bug 3025

Fix multipart srun submission with EnforcePartLimits=NO and job violating
    the partition limits.
bug 3025

bug 3011

both)  Continuation of commit 95fa8e8e.

# Conflicts:
#	Makefile.in
#	auxdir/Makefile.in
#	contribs/Makefile.in
#	contribs/cray/Makefile.in
#	contribs/cray/csm/Makefile.in
#	contribs/lua/Makefile.in
#	contribs/mic/Makefile.in
#	contribs/openlava/Makefile.in
#	contribs/pam/Makefile.in
#	contribs/pam_slurm_adopt/Makefile.in
#	contribs/perlapi/Makefile.in
#	contribs/perlapi/libslurm/Makefile.in
#	contribs/perlapi/libslurmdb/Makefile.in
#	contribs/phpext/Makefile.in
#	contribs/pmi2/Makefile.in
#	contribs/seff/Makefile.in
#	contribs/sgather/Makefile.in
#	contribs/sgi/Makefile.in
#	contribs/sjobexit/Makefile.in
#	contribs/slurmdb-direct/Makefile.in
#	contribs/torque/Makefile.in
#	doc/Makefile.in
#	doc/html/Makefile.in
#	doc/man/Makefile.in
#	doc/man/man1/Makefile.in
#	doc/man/man3/Makefile.in
#	doc/man/man5/Makefile.in
#	doc/man/man8/Makefile.in
#	etc/Makefile.in
#	src/Makefile.in
#	src/api/Makefile.in
#	src/bcast/Makefile.in
#	src/common/Makefile.in
#	src/database/Makefile.in
#	src/db_api/Makefile.in
#	src/layouts/Makefile.in
#	src/layouts/power/Makefile.in
#	src/layouts/unit/Makefile.in
#	src/plugins/Makefile.in
#	src/plugins/accounting_storage/Makefile.in
#	src/plugins/accounting_storage/common/Makefile.in
#	src/plugins/accounting_storage/filetxt/Makefile.in
#	src/plugins/accounting_storage/mysql/Makefile.in
#	src/plugins/accounting_storage/none/Makefile.in
#	src/plugins/accounting_storage/slurmdbd/Makefile.in
#	src/plugins/acct_gather_energy/Makefile.in
#	src/plugins/acct_gather_energy/cray/Makefile.in
#	src/plugins/acct_gather_energy/ibmaem/Makefile.in
#	src/plugins/acct_gather_energy/ipmi/Makefile.in
#	src/plugins/acct_gather_energy/none/Makefile.in
#	src/plugins/acct_gather_energy/rapl/Makefile.in
#	src/plugins/acct_gather_filesystem/Makefile.in
#	src/plugins/acct_gather_filesystem/lustre/Makefile.in
#	src/plugins/acct_gather_filesystem/none/Makefile.in
#	src/plugins/acct_gather_infiniband/Makefile.in
#	src/plugins/acct_gather_infiniband/none/Makefile.in
#	src/plugins/acct_gather_infiniband/ofed/Makefile.in
#	src/plugins/acct_gather_profile/Makefile.in
#	src/plugins/acct_gather_profile/hdf5/Makefile.in
#	src/plugins/acct_gather_profile/hdf5/sh5util/Makefile.in
#	src/plugins/acct_gather_profile/hdf5/sh5util/libsh5util_old/Makefile.in
#	src/plugins/acct_gather_profile/none/Makefile.in
#	src/plugins/auth/Makefile.in
#	src/plugins/auth/munge/Makefile.in
#	src/plugins/auth/none/Makefile.in
#	src/plugins/burst_buffer/Makefile.in
#	src/plugins/burst_buffer/common/Makefile.in
#	src/plugins/burst_buffer/cray/Makefile.in
#	src/plugins/burst_buffer/generic/Makefile.in
#	src/plugins/checkpoint/Makefile.in
#	src/plugins/checkpoint/aix/Makefile.in
#	src/plugins/checkpoint/blcr/Makefile.in
#	src/plugins/checkpoint/none/Makefile.in
#	src/plugins/checkpoint/ompi/Makefile.in
#	src/plugins/checkpoint/poe/Makefile.in
#	src/plugins/core_spec/Makefile.in
#	src/plugins/core_spec/cray/Makefile.in
#	src/plugins/core_spec/none/Makefile.in
#	src/plugins/crypto/Makefile.in
#	src/plugins/crypto/munge/Makefile.in
#	src/plugins/crypto/openssl/Makefile.in
#	src/plugins/ext_sensors/Makefile.in
#	src/plugins/ext_sensors/none/Makefile.in
#	src/plugins/ext_sensors/rrd/Makefile.in
#	src/plugins/gres/Makefile.in
#	src/plugins/gres/gpu/Makefile.in
#	src/plugins/gres/mic/Makefile.in
#	src/plugins/gres/nic/Makefile.in
#	src/plugins/job_container/Makefile.in
#	src/plugins/job_container/cncu/Makefile.in
#	src/plugins/job_container/none/Makefile.in
#	src/plugins/job_submit/Makefile.in
#	src/plugins/job_submit/all_partitions/Makefile.in
#	src/plugins/job_submit/cray/Makefile.in
#	src/plugins/job_submit/defaults/Makefile.in
#	src/plugins/job_submit/logging/Makefile.in
#	src/plugins/job_submit/lua/Makefile.in
#	src/plugins/job_submit/partition/Makefile.in
#	src/plugins/job_submit/pbs/Makefile.in
#	src/plugins/job_submit/require_timelimit/Makefile.in
#	src/plugins/job_submit/throttle/Makefile.in
#	src/plugins/jobacct_gather/Makefile.in
#	src/plugins/jobacct_gather/aix/Makefile.in
#	src/plugins/jobacct_gather/cgroup/Makefile.in
#	src/plugins/jobacct_gather/common/Makefile.in
#	src/plugins/jobacct_gather/linux/Makefile.in
#	src/plugins/jobacct_gather/none/Makefile.in
#	src/plugins/jobcomp/Makefile.in
#	src/plugins/jobcomp/elasticsearch/Makefile.in
#	src/plugins/jobcomp/filetxt/Makefile.in
#	src/plugins/jobcomp/mysql/Makefile.in
#	src/plugins/jobcomp/none/Makefile.in
#	src/plugins/jobcomp/script/Makefile.in
#	src/plugins/launch/Makefile.in
#	src/plugins/launch/aprun/Makefile.in
#	src/plugins/launch/poe/Makefile.in
#	src/plugins/launch/runjob/Makefile.in
#	src/plugins/launch/slurm/Makefile.in
#	src/plugins/mcs/Makefile.in
#	src/plugins/mcs/group/Makefile.in
#	src/plugins/mcs/none/Makefile.in
#	src/plugins/mcs/user/Makefile.in
#	src/plugins/mpi/Makefile.in
#	src/plugins/mpi/lam/Makefile.in
#	src/plugins/mpi/mpich1_p4/Makefile.in
#	src/plugins/mpi/mpich1_shmem/Makefile.in
#	src/plugins/mpi/mpichgm/Makefile.in
#	src/plugins/mpi/mpichmx/Makefile.in
#	src/plugins/mpi/mvapich/Makefile.in
#	src/plugins/mpi/none/Makefile.in
#	src/plugins/mpi/openmpi/Makefile.in
#	src/plugins/mpi/pmi2/Makefile.in
#	src/plugins/mpi/pmix/Makefile.in
#	src/plugins/node_features/Makefile.in
#	src/plugins/node_features/knl_cray/Makefile.in
#	src/plugins/power/Makefile.in
#	src/plugins/power/common/Makefile.in
#	src/plugins/power/cray/Makefile.in
#	src/plugins/power/none/Makefile.in
#	src/plugins/preempt/Makefile.in
#	src/plugins/preempt/job_prio/Makefile.in
#	src/plugins/preempt/none/Makefile.in
#	src/plugins/preempt/partition_prio/Makefile.in
#	src/plugins/preempt/qos/Makefile.in
#	src/plugins/priority/Makefile.in
#	src/plugins/priority/basic/Makefile.in
#	src/plugins/priority/multifactor/Makefile.in
#	src/plugins/proctrack/Makefile.in
#	src/plugins/proctrack/aix/Makefile.in
#	src/plugins/proctrack/cgroup/Makefile.in
#	src/plugins/proctrack/cray/Makefile.in
#	src/plugins/proctrack/linuxproc/Makefile.in
#	src/plugins/proctrack/lua/Makefile.in
#	src/plugins/proctrack/pgid/Makefile.in
#	src/plugins/proctrack/sgi_job/Makefile.in
#	src/plugins/route/Makefile.in
#	src/plugins/route/default/Makefile.in
#	src/plugins/route/topology/Makefile.in
#	src/plugins/sched/Makefile.in
#	src/plugins/sched/backfill/Makefile.in
#	src/plugins/sched/builtin/Makefile.in
#	src/plugins/sched/hold/Makefile.in
#	src/plugins/sched/wiki/Makefile.in
#	src/plugins/sched/wiki2/Makefile.in
#	src/plugins/select/Makefile.in
#	src/plugins/select/alps/Makefile.in
#	src/plugins/select/alps/libalps/Makefile.in
#	src/plugins/select/alps/libemulate/Makefile.in
#	src/plugins/select/bluegene/Makefile.in
#	src/plugins/select/bluegene/ba/Makefile.in
#	src/plugins/select/bluegene/ba_bgq/Makefile.in
#	src/plugins/select/bluegene/bl/Makefile.in
#	src/plugins/select/bluegene/bl_bgq/Makefile.in
#	src/plugins/select/bluegene/sfree/Makefile.in
#	src/plugins/select/cons_res/Makefile.in
#	src/plugins/select/cray/Makefile.in
#	src/plugins/select/linear/Makefile.in
#	src/plugins/select/other/Makefile.in
#	src/plugins/select/serial/Makefile.in
#	src/plugins/slurmctld/Makefile.in
#	src/plugins/slurmctld/nonstop/Makefile.in
#	src/plugins/slurmd/Makefile.in
#	src/plugins/switch/Makefile.in
#	src/plugins/switch/cray/Makefile.in
#	src/plugins/switch/generic/Makefile.in
#	src/plugins/switch/none/Makefile.in
#	src/plugins/switch/nrt/Makefile.in
#	src/plugins/switch/nrt/libpermapi/Makefile.in
#	src/plugins/task/Makefile.in
#	src/plugins/task/affinity/Makefile.in
#	src/plugins/task/cgroup/Makefile.in
#	src/plugins/task/cray/Makefile.in
#	src/plugins/task/none/Makefile.in
#	src/plugins/topology/3d_torus/Makefile.in
#	src/plugins/topology/Makefile.in
#	src/plugins/topology/hypercube/Makefile.in
#	src/plugins/topology/node_rank/Makefile.in
#	src/plugins/topology/none/Makefile.in
#	src/plugins/topology/tree/Makefile.in
#	src/sacct/Makefile.in
#	src/sacctmgr/Makefile.in
#	src/salloc/Makefile.in
#	src/sattach/Makefile.in
#	src/sbatch/Makefile.in
#	src/sbcast/Makefile.in
#	src/scancel/Makefile.in
#	src/scontrol/Makefile.in
#	src/sdiag/Makefile.in
#	src/sinfo/Makefile.in
#	src/slurmctld/Makefile.in
#	src/slurmd/Makefile.in
#	src/slurmd/common/Makefile.in
#	src/slurmd/slurmd/Makefile.in
#	src/slurmd/slurmstepd/Makefile.in
#	src/slurmdbd/Makefile.in
#	src/smap/Makefile.in
#	src/smd/Makefile.in
#	src/sprio/Makefile.in
#	src/squeue/Makefile.in
#	src/sreport/Makefile.in
#	src/srun/Makefile.in
#	src/srun/libsrun/Makefile.in
#	src/srun_cr/Makefile.in
#	src/sshare/Makefile.in
#	src/sstat/Makefile.in
#	src/strigger/Makefile.in
#	src/sview/Makefile.in
#	testsuite/Makefile.in
#	testsuite/expect/Makefile.in
#	testsuite/slurm_unit/Makefile.in
#	testsuite/slurm_unit/api/Makefile.in
#	testsuite/slurm_unit/api/manual/Makefile.in
#	testsuite/slurm_unit/common/Makefile.in

If all GRES were not defined on all nodes OR if a regular expression was used
   for a GRES file configuration (e.g. in gres.conf
   "Type=gpu Files=/dev/nvidia[0-4]"), then memory corruption was likely.
   The logic has been bad since its inception several years ago.

was put in as 4294967294 instead of -2.

POLLRDHUP does not exist on BSD, define to POLLHUP as done elsewhere.

Linux manages to work around it, but FreeBSD definitely requires it.

Dependency from use of pthread_kill(), introduced in dd4990a2.

Revert commit 933d4fba
bug 2704

Problem reported by Coverity

The original logic in c69650a9
  was flawed. This commit removes that logic. New logic is still
  required for proper enforcement.

The attached patch switches to a more reliable method of detecting
service nodes, using xtcli status. In addition, it switches to the print
function to be better compatible with python 3.

Remove DelayBoot configuration parameter from knl.conf and move to
  SchedulerParameters.
Set job default delay_boot value from configuration parameter
Enforce delay-boot scheduling logic.

multiple versions.

on the most recent pmix_vX.so file.
One is free to directly use new "pmix_vX" plugin names as well.

NOTE: there is one small artifact introduced by this fix - there will be
no "pmix" name in the output of "srun --mpi=list" but the most recent plugin
will be duplicated:

$ ./srun --mpi=list
srun: MPI types are...
srun: mpi/none
srun: mpi/mvapich
srun: mpi/mpich1_shmem
srun: mpi/mpichgm
srun: mpi/pmix_v1      <----
srun: mpi/mpichmx
srun: mpi/lam
srun: mpi/pmi2
srun: mpi/openmpi
srun: mpi/mpich1_p4
srun: mpi/pmix_v1      <----

conflicting pmix versions.