The job write lock is required here, not just job read.

Bug 6508.

Continuation of bf63629e.

Bug 1394, 6436.

# Conflicts:
#	doc/man/man1/scontrol.1
#	doc/man/man5/slurm.conf.5
#	src/common/gres.c

Clear the JOB_STAGE_OUT flag once the stage out is complete.

Bug 6429.

If DISPLAY is a local UNIX socket, return 0 for the port number,
and an xmalloc()'d string as the target option.

Rename x11_target_host to x11_alloc_host to better indicate what the value
represents. Going forward, the x11_alloc_host and x11_alloc_port are the
hostname and TCP port number to connect to get the tunnel established.

The x11_target and x11_target_port fields indicate which X11 display to
connect to. If x11_target_port is zero, this indicates that x11_target
is a UNIX socket on x11_alloc_host. Otherwise, x11_target is the hostname
associated with the TCP port in x11_target_port for the DISPLAY.

Make careful changes to older protocol blocks to ensure the 17.11/18.08
slurmd processes can receive sufficient details from 19.05 slurmctld to
setup SSH-based forwarding.

Bug 6500

Bug 5717

Bug 5717

This fixes a few issues the old sql didn't work with.  All these are
verified with test12.10.

Bug 5717

This adds a new helper function slurmdb_job_cond_def_start_end
This will set default usage times when getting jobs from the database.

Bug 5717

Bug 5717

Bug 6263

These tests previously assumed that one task could be launched
per CPU, which is not necessarily the case

Make it clear when the HealthCheckProgram will run and what state the
node will be in during that time.
Clear up other things.

Bug 6391

If CR_ONE_TASK_PER_CORE is configured then the core count rather
than the CPU count of a node is used to determine if a node can
be used by a job. This can result in a job being rejected than
should be able to run. Sample configuration and job below:
SelectTypeParameters=CR_Core_Memory,CR_CORE_DEFAULT_DIST_BLOCK,CR_ONE_TASK_PER_CORE
NodeName=psg-dgx2-01 NodeAddr=jette NodeHostName=jette RealMemory=1536000 Gres=gpu:16 Sockets=2 CoresPerSocket=24 ThreadsPerCore=2 State=UNKNOWN

$ srun --gpus-per-task=1 -n1 --cpus-per-gpu=64 -J test39.7 -t1 ./test39.7.input
srun: error: CPU count per node can not be satisfied
srun: error: Unable to allocate resources: Requested node configuration is not available
bug 6517

This should never happen, but might be recoverable. Log the event,
pack zeros, and continue.

bug 6534

Need to modify other uses of adjust_cpus_nppcu()

This patch better describes the always enabled TRES values for
AccountingStorageTRES.

Bug 6506

Recognize when a job either did or did not explicitly specify the
--cpus-per-task option so that we can allocate more CPUs as appropriate
to satisfy --cpus-per-gpu and related option.

If a job submit does NOT include --cpus-per-task option, then report the
value as "N/A" rather than always mapping the value to 1.

No changes to data structure yet, just adding different un/pack
test for v19.05.

No functional change.

Bug 6210 and 6262.

No functional change.

Bug 6210 and 6262.

Bug 6210 and 6262.

# Conflicts:
#	doc/man/man1/salloc.1
#	src/salloc/opt.c

Previously some samples/sizes were reported as total accumulated values
instead of deltas or were reported after an underflow occurred.

Bug 6210 and 6262.

Bug 6278

Bug 6278

# Conflicts:
#	doc/man/man5/slurm.conf.5

This is helpful when running multiple versions against the same build.

i.e.
globals.snowflake
globals.knc
...