User-submitted batch scripts cannot be safely escaped. This functionality
will be replaced with a way to retrieve the script directly into a file
for a given jobid.

This also removes the 'script' command from scontrol's interactive
cli mode.

Writes to slurm-<jobid>.sh if no (optional) filename is specified.

Bug 4199.

Move the check up a bit more where it'll do some good.

Bug 4184.

Bug 4146.

Bug 3467

Bug 3567

Add ability to prevent suspension of some count of nodes in a specified
    range using the SuspendExcNodes configuration parameter.

instead of native Slurm.

gres listed in your slurm.conf but some in gres.conf.

Bug 3974

'type' but no file defined.

Add support for specialized cores with task/affinity plugin (previously
    only supported with task/cgroup plugin).
Add "TaskPluginParam=SlurmdOffSpec" option that will prevent the Slurm
    compute node daemons (slurmd and slurmstepd) from executing on specialized
    cores.
bug 3337

in salloc, sbatch, srun before process the command line options.
Bug 3499

plugin when constraining devices.

correctly in sacct.

A second PMI2_Init() within the same step is invalid, and cannot succeed.

Return an error code back to the client end, and close the fd to force the
step to terminate immediately.

Due to a bug in our libpmi code, just returning a cmd=response_to_init with
an appropriate rc number will not tear down the connection properly, so
send back something else that will trigger the error path.

Bug 3520.

A request to cancel a pack step leader will result in that step
  being cancelled on all pack job components. Needed by MPI.

mpi/pmi2 plugin - vestigial pointer could be referenced at shutdown with
    invalid memory reference resulting.

Bug 4154.

Use the partition specified in the reservation, rather than
using the cluster's default.

Bug 4030.

default path.

This makes it so you don't always have to put AllowedDevicesFile in your
cgroup.conf file if your etc dir is anything other than /etc/slurm.

Don't flag a job as "SPAWNED" for debugger until all process
  information is available for all pack job components.

Adding a newline prevents this error:
conftest.c:154:8: error: if statement has empty body [-Werror,-Wempty-body]

remote cluster correctly determine the select type.

Bug 2329

Modify "srun --mpi=list" output to match valid option input by removing the
    "mpi/" prefix on each line of output.

Enable them onlyh with SchedulerParameters=enable_hetero_jobs OR
  MPI type is "none"

Do pointer comparisons rather than strcmps.
~80x speedup
Bug 3529

e.g.
1000 nodes
8000 tasks
[Sep 11 14:24:15.873639 20992 srvcn        0x7f8c1cdda700] _task_layout_hostfile: hostfile processing took usec=2152678 (orig)
[Sep 11 14:27:46.173424 20992 srvcn        0x7f8c1c6d3700] _task_layout_hostfile: hostfile processing took usec=2142997 (orig)
[Sep 11 14:32:32.245420  4037 srvcn        0x7f12de4e4700] _task_layout_hostfile: hostfile processing took usec=26198 (node ptrs)
[Sep 11 14:36:12.88769   4037 srvcn        0x7f12de6e6700] _task_layout_hostfile: hostfile processing took usec=25515 (node ptrs)
[Sep 11 14:41:38.339162  4037 srvcn        0x7f132c8d5700] _task_layout_hostfile: hostfile processing took usec=27459 (node ptrs)
[Sep 11 15:16:59.575189  1874 srvcn        0x7f3dae3f0700] _task_layout_hostfile: hostfile processing took usec=30129 (node ptrs)
[Sep 11 15:20:50.365004  1874 srvcn        0x7f3dc8b34700] _task_layout_hostfile: hostfile processing took usec=29884 (node ptrs)

If /proc was inaccessible proc_name would leak.

Put an explicit length cap in sprintf to avoid warning. The
size is checked immediate before here so this is just making
the 10-char limit explicit.

Bug 4062.

If the network path to shared storage used for the StateSaveLocation
is separate from that used to communicate with the cluster, both the
primary and backup controllers can end up acting as master on loss
of the cluster network.

Alter the HA takeover code path to make sure that the job state
save file is not still being updated by the primary slurmctld.
If it is, refuse to takeover and retry again later.

Bug 3592.

Bug 4062.