Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • autosubmit autosubmit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 338
    • Issues 338
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Earth SciencesEarth Sciences
  • autosubmitautosubmit
  • Merge requests
  • !488

#1397: Use tini as entrypoint in our Docker image

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Bruno de Paula Kinoshita requested to merge gl-1397 into master Sep 09, 2024
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Closes #1397 (closed)

@mcastril I had said before that Docker was able to magically use tini, and it's indeed true, with docker --init. But on this MR we force that even if the user does not use --tini. We install tini with apt-get (Docker has tini outside of the image), and then run tini -- $old-entry-point. That's all it takes to have tini as root PID, reaping for zombies (it's limited if compared to systemd, but it does reap).

Whoever reviews this, here's how I tested it locally:

$ cd docker
$ docker build -t kinow/autosubmit-4.1.11-dev .
$ docker run --rm -ti kinow/autosubmit-4.1.11-dev /bin/bash
$ autosubmit> # try some commands if you'd like
$ docker run --rm -ti kinow/autosubmit-4.1.11-dev
$ docker run --rm -ti kinow/autosubmit-4.1.11-dev autosubmit -v
# warnings... that we will fix later, ignore
4.1.10

Cheers

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gl-1397