sched/backfill - Fix logic to reserve resources for jobs that require a
    node reboot (i.e. to change KNL mode) in order to start.
bug 3346

go into JobAdminHeld.

Bug 3201

Fix for possible infinite loop in select/cons_res plugin when trying to
    satisfy a job's ntasks_per_core or socket specification.
bug 3329

Bug 2992.

Modify regression test1.89 to avoid leaving vestigial job. Also reduce
    logging to reduce likelyhood of Expect buffer overflow.
bug 3273

Reverts most of commit 84023f27.

Searching the PATH in slurmd can fail due to root_squash'd NFS
filesystems, leading to the "wrong" program being launched.

If you'd like the performance benefit from avoiding this lookup
during each separate task launch, set SLURM_TEST_EXEC=1 instead
which will perform the lookup once within srun, which then ensures
the lookup happens under the users own environment and not that
of the slurmd.

Bug 2992.

If running burst_buffer/cray plugin on emulated Cray (NOT a real
   Cray system with Cray APIs) and the burst buffer state information
   includes information about buffers associated with jobs which
   are either completed or no longer exist (i.e. the burst buffer
   state information is old), then ignore that old state information.
   This might possibly be related to bug 3295 if their configuration
   is bad.

level.

Revise commit e6ef1f0c
The root cause of the failure is a bug in HWLOC that has since
been fixed in HWLOC version 1.11.5.

If the second call to getgrouplist() found additional groups,
ngroups will be overwritten with this new larger value, while
the gids list would be truncated. (ngroups is a value-result arg.)
This will then lead to _gids_cache_lookup() returning the wrong
number of groups including invalid parts of memory, which are likely
to include some zeros.

Those zeros could then make it to the setgroups() call and thus
give the user access to the root group. Especially as setgroups
will succeed as long as the array does not contain -1 as a gid.

Bug 3320.

task/cgroup - Change error message if CPU binding can not take place to
    better identify the root cause of the problem. Specifically, if
    the hwloc_get_obj_below_by_type() function call completely fails
    that is likely due to task/affinity not being configured, so
    cpusets are not configured. Previous message was
    "task/cgroup: task[%u] infinite loop broken while trying to provision compute elements using %s (bitmap:%s)"
    The new message is
    "task/cgroup: hwloc_get_obj_below_by_type() failing, task/affinity plugin also required"

uint32_t needs %u on 32-bit platforms. Noticed by clang/travisci.

Bug 3258

This reverts commit 55cb7973.

This reverts commit 817c2ca4.

# Conflicts:
#	NEWS

a slurmctld restart or reconfig, as they aren't really error messages.

Bug 3258

Bug 3258

Done jost to run "git push" again after internal github error on
  previous push:
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
remote: Unexpected system error after push was received.
remote: These changes may not be reflected on github.com!
remote: Your unique error code: bdecb7b0f321368fe1f037a81a6e9c2c

This restores the socket count check at node registration for
  non-KNL systems (at least systems without NodeFeaturesPlugins
  type that includes "knl"). This is a refinement of commit
  1ce9a7c4

Note that this does not protect against all possible problems here.
The setgroups() call in Linux at least is willing to set any gid_t
value except -1 on a group, so calls will not always fail on corrupted
group lists.

Bug 3320.

Remove uncached _get_grouplist() call which was only used here.

Bug 3315.

test12.2 was consistently failing on smd# cluster with tiny differences
  in the disk read and written. This change permits those tiny discrepancies
  to exist without failing the test.
  Here are the numbers, which are consistent:

  sacct --noheader -p --job=763.0 --format MaxDiskWrite,AveDiskWrite,MaxDiskRead,AveDiskRead
  10.00M|10.00M|10.03M|10.03M|
  (i.e. 0.3% discrepancy, up to 0.5% allowed with current code)

Test was failing due to hitting the memory limit (at least on smd1).

There were already several configurations that could cause this test
  to fail. I just added another.

Fix parsing in regression test1.92 for some prompts.
bug 2792

Recognize a KNL's proper NUMA count (rather than setting it to the value
    in slurm.conf) when using FastSchedule=0. Previous logic would change
    the NUMA count on the node to match what was in slurm.conf, which would
    mess up task layout with respect to the sockets.
bug 3306

HWLOC is required to properly determine topology

from the slurm.conf when using FastSchedule=0.