Patch from Martin Perry.

SelectType=select/cons_res
SelectTypeParameters=CR_Socket

Slurm built with ALLOCATE_FULL_SOCKET = 1

Node n8 has the following layout:
Socket 0: CPUs 0-3
Socket 1: CPUs 4-7

Without fix to _allocate_sockets (incorrect allocation for -c values of 3, 5, 6, and 7):

[sulu] (slurm) etc> srun -c1 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=4-7 Mem=0
[sulu] (slurm) etc> srun -c2 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=4-7 Mem=0
[sulu] (slurm) etc> srun -c3 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=0-3 Mem=0
[sulu] (slurm) etc> srun -c4 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=4-7 Mem=0
[sulu] (slurm) etc> srun -c5 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=0-4 Mem=0
[sulu] (slurm) etc> srun -c6 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=0-5 Mem=0
[sulu] (slurm) etc> srun -c7 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=0-6 Mem=0
[sulu] (slurm) etc> srun -c8 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=0-7 Mem=0

With fix to _allocate_sockets (allocation appears correct for all values of -c):

[sulu] (slurm) etc> srun -c1 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=4-7 Mem=0
[sulu] (slurm) etc> srun -c2 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=4-7 Mem=0
[sulu] (slurm) etc> srun -c3 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=4-7 Mem=0
[sulu] (slurm) etc> srun -c4 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=4-7 Mem=0
[sulu] (slurm) etc> srun -c5 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=0-7 Mem=0
[sulu] (slurm) etc> srun -c6 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=0-7 Mem=0
[sulu] (slurm) etc> srun -c7 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=0-7 Mem=0
[sulu] (slurm) etc> srun -c8 -m block:block --jobid 1 scontrol --details show job 1 | grep CPU_ID
     Nodes=n8 CPU_IDs=0-7 Mem=0
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A

Without this change, an assert can occur when operating bitmaps of differrent sizes

Patch by Bill Brophy, Bull.

You'll find this as commit 2079c03f58 to the chaos/slurm 2.3.3.chaos branch on March 7.  This is against SchedMD's master branch:

Patch by Don Lipari, LLNL.
https://github.com/chaos/slurm/commit/4de11bf0a8cd18207a60e7d3e1fa7a6fde0da431

Move a log message before fork() call in the new spank prolog/epilog
logic. The original code could deadlock in glibc when getting the time
to include in the message.

If the select plugin does not allocate memory to a job, then do not
try to alloocate memory to the job step, without this the step allocation
will always fail

Merge branch 'spank-epilog-for-schedmd' of https://github.com/grondo/slurm into grondo-spank-epilog-for-schedmd

Conflicts:
	NEWS

Fix bug in allocating GRES that are associated with specific CPUs. In some
cases the code allocated first available GRES to job instead of allocating
GRES accessible to the specific CPUs allocated to the job.

Mistakenly changed jobacct_gather_g_getinfo() into
jobacct_gather_g_setinfo()

This avoids conflicts with the "info" function.

This fixes a race condition in error handling logic added a couple
of days ago for slurmd/slurmstepd communications in commit
https://github.com/SchedMD/slurm/commit/ed31e6c7fdb5bcc1b0f0a8e3cbf5327604e64887

Access to secured FS often requires to have a valid token in the
user context. With SLURM, this token can be obtained using one of
the possible pluggable architecture, SPANK or PAM.

IO setup of SLURM can require to access secured FS (stdout/stderr
files). This patch ensures that pluggable frameworks are activated
and called prior to IO setup and that IO are terminated before
calling pluggable framework exit calls.

set PR_DUMPABLE as soon as possible, especially before any plugins
are loaded. This will allow someone debugging to get a coredump.

To prepare io_setup integration in _fork_all_tasks, error handling
must be transformed to not always return SLURM_ERROR but be prepared
to return SLURM_SUCCESS in case of an io_setup error.

Update spank(8) man page with documentation of new functionality,
including new callbacks: slurm_spank_slurmd_init, slurm_spank_slurmd_exit,
slurm_spank_job_prolog, and slurm_spank_job_epilog, as well as the new
spank_option_getopt() call for use in option processing by plugins.