This shouldn't happen in practice, but fixes CLANG error

The field requires an argument, but CLANG assumes none...

Error reported by CLANG

Reported by CLANG

Reported by CLANG

Previous logic would not detect lack of "processor" ID or problem
parsing "physical id". This logs the problem as an error.

Link to build, add site_factor/none as the default (null) plugin.

Connect in to priority_multifactor plugin.

Note that the job_write_lock acquisition in _decay_thread() is promoted
one level to protect both the fair tree use of it alongside the new
site_factor plugin. As fair_tree has been made the default, I felt it was
better to handle it this way, rather than have site_factor reacquire the
locks right after fair_tree dropped them. For sites running without
fair_tree, this does represent a minor drop in potential concurrency.

Bug 5202.

Ensure the file has been create with the appropriate length before
mmap()'ing the buffer.

This was a false-positive in Coverity, and extending the mmap()
to silence that warning is incorrect.

This reverts commit ac5d85d5.

HAVE_NATIVE_CRAY is equivalent at this point.

HAVE_REAL_CRAY is equivalent to HAVE_NATIVE_CRAY at this point.

One level up - src/plugins/proctrack/Makefile.am - will only build
proctrack/cray if HAVE_NATIVE_CRAY is set, so this test against
HAVE_REAL_CRAY is redundant.

Cray Aries systems do not run with --enable-frontend, so this is redundant.
(But was previously relevant for Cray ALPS support.)

Coverity CID 45153

Coverity CID 45163

Coverity CID 45162

This eliminates code that's dead on non-cray systems
Coverity CID 44818

Check for negative index

Add "return" after "fatal()" to avoid error
Coverity CID 45267

Coverity CID 187084

This eliminates a resource leak error from Coverity
Coverity CID 174433

Coverity CID 45041

Coverity CID 178897

This shouldn't happen in practice, but prevent the possibility
Coverity CID 182987

This shouldn't happen in practice, but prevent its possibility
Coverity CID 182988

Clears Coverity error

Coverity CID 195596

Fix format of comments