Prevent scheduling deadlock with multiple components of heterogeneous job
    in different partitions (i.e. one heterogeneous job component is higher
    priority in one partition and another component is lower priority in a
    different partition).
bug 4370

Issue could be reproduced by restarting slurmctld after a heterogeneous job
finished, but before MinJobAge time passed. Since the pack_job_list
job_record memeber wasn't saved/loaded to/from the job_state, the function
_validate_pack_jobs() is responsible for rebuilding the pack_job_list. Issue
was that the function was skiping the rebuild work for finished jobs, thus
other functions like the thread responsible for purging old jobs was failing
to iterate over a NULL pack_job_list which was never rebuilt.

Bug 4383.

If run from srun and lua job submit plugin sets environment, slurmctld
crashes.

Bug#4247

From within slurm_job_submit():
	job_desc.pack_job_offset

From within slurm_job_modify():
	job_rec.pack_job_id
	job_rec.pack_job_id_set
	job_rec.pack_job_offset

Bug 4372.

bug 4339

added some additional checks to prevent segfaults in some basic situations.
Bug 4247

bug 4368

Add SLURM_PACK_JOB_ID and SLURM_PACK_JOB_OFFSET to PrologSlurmctld and
  EpilogSlurmctld environment
bug 4379

Avoid srun abort trying to run on heterogeneous job component that has
    ended.
bug 4366

bug 4374

Do so even if pack-group 0 is completed, so long as not all components are completed
bug 4374

In a prior incarnation of the patch that introduced it,
it was MaxQueryTimeLimit, and that was not updated with
the code base when changed.

Bug 4365.

Update slurm.spec and slurm.spec-legacy as well

Bug 4323.

This now matches the sinfo documentation.

Bug 4306.

The race condition this is avoiding has been fixed elsewhere.

This reverts commit 6c21c8bd.

Coverity 178912

Coverity CID 178913

Removed references to versions <=16.05 and adapted to new 17.11

launch/slurm plugin - Avoid using global variable for heterogeneous job
    steps, which could corrupt memory.
bug 4333

Ancient versions of OpenMPI and their derivatives (i.e. Cray MPI) are
dependent upon communication ports being assigned to them by Slurm. Such MPI
jobs will experience step launch failure if any component of a
heterogeneous job step is unable to acquire the allocated ports.
Non-heterogeneous job steps will retry step launch using a new set of
communication ports (no change in Slurm behavior).

NOTE: Correcting this would necessitate assigning the same set of ports
to all components of the heterogeneous job (not possible today) plus changes to
srun in order to better synchronize the step startup and error handling.

Same logic as done in commit fb296c70 done for energy.

Bug 4336

If heterogeneous job step is unable to acquire MPI reserved ports then
    avoid referencing NULL pointer.
bug 4333

Force tres change on a job to send data to the database.

This should be happening already, but this just makes it always happen.

This fixes the possibility of going into this loop when we hadn't
setup the tres_req_cnt.  The simple case Coverity reported is if the
job is already finished it goes here and we never set up tres_req_cnt.

Coverity CID 178897

This fixes the possibility of referencing a NULL pointer if the
reservation doesn't exist anymore when testing.

Coverity CID 178898

Bug 3647.

Bug 4353.

Also collapse a nested %{with cray} block leftover from earlier work.

Bug 4332.

Logic was inverted from the correct behavior.

Bug 4332.

Slurm package should not try to manage configs; leave this to the
admin to setup as they wish. This avoids an issue on RPM install if
/etc/slurm is a symlink to somewhere else.

Bug 4332.

Bug 4332.