helgrind found that the locks were taken in reverse order in some
places. This makes the ordering of locks consistent.

    an maintenance reservation that is not active yet.

work "partition".

reference bug 1246

always and it scares people.

is requested.

This is a re-factor of commit e5635a76 related to bug 1148 to handle
the cases where a job could run, but an error was given when selecting
the nodes.

lock was locked outside of the function or not.  This also fixes a race
condition when adding a QOS and planning on using it right away when the
controller is busy with previous requests.

PerCPU.

Before it wasn't taking into account if the user was requesting per node
memory or the job was told it needed to use less than the node allowed.

This was an unrealized regression from commit 0da01963.  The problem
is we were clearing the job_ptr->job_resrcs too early.  This patch fixes
it to wait until the job is actually being requeued so it does the right
thing.

pack it this way so we will not change it in 15.08

This isn't that big of an issue for 14.03, but 14.11 added more to this
string which could overflow the buffer since sprintf is used instead of
snprintf.  Using xstrfmtcat fixes the issue and is easier to read code.

amount of tasks / number of node.

to dereference it.

are specified.

This is a fix to commit b9cc5b31 which just didn't know
mc_ptr->ntasks_per_core is initialized to INFINITE.  Without it the
node_cnt packed would be set to 1 on the user tools.

This fixes bug 1148.

bug 1207

Use default_partition by default for the test

Returned test passed, when it should have failed because of bad
variable name.

We've seen slurmctld crashes due to negative job array indices.

The previous patch should work in most cases, but this should
work more reliably and the comment is more clear
bug 1196

This reverts commit 7e65f924.

BGQ: Fix race condition when job fails due to hardware failure and is
requeued. Previous code could result in slurmctld abort with NULL pointer.
bug 1096

Fix bug that prevented preservation of a job's GRES bitmap on slurmctld
restart or reconfigure (bug was introduced in 14.03.5 "Clear record of a
job's gres when requeued" and only applies when GRES mapped to specific
files).
bug 1192

permission for the batch step.

Otherwise there will be no log file to write to, resulting in an
abort
bug 1185