Bug 5724

For some reason this file had all sorts of bad indenting.

Bug 5724

Bug 5708

This matches the functionality in code.

Bug 5726

Bug 5795

Continuation of 06582da8 (17.11.9)

Poll was timing out too quickly due to an incorrect conversion of
MessageTimeout. Added a multiplier so timeout reflects the correct
millisecond value.

Bug 5553

# Conflicts:
#	src/common/slurm_protocol_pack.c
#	src/slurmctld/controller.c

Since sacct exits the program when it finds unknown parameters, the
debug2() statements should be escalated to error() statements.
The first debug2() even had "Error: " in it.
Get rid of extra newline.

Bug 5421

Bug 5786

Bug 5165

Bug 5743.

Co-authored-by: Dominik Bartkiewicz <bart@schedmd.com>

Bug 5165

It was still possible for job priority to go down to 0, because I was
letting last_prio get set down to 1, then later on we were using
last_prio-1 as the new job priority. Since last_prio was 1, then new
job priority was 1-1=0. This happened when the job priorities were all
at 2 (which I never tested). Michael found it by running test2.26 in a
case where initial job priorities were 2:

spawn /home/marshall/slurm/18.08/voyager/bin/squeue --name=test2.26 -o JOB_ID=%A PRIO=%Q
JOB_ID=JOBID PRIO=PRIORITY
JOB_ID=10702 PRIO=2
JOB_ID=10703 PRIO=2
JOB_ID=10704 PRIO=2
Reset and test job priorities

spawn /home/marshall/slurm/18.08/voyager/bin/scontrol top 10704,10703
spawn /home/marshall/slurm/18.08/voyager/bin/squeue --name=test2.26 -o JOB_ID=%A PRIO=%Q
JOB_ID=JOBID PRIO=PRIORITY
JOB_ID=10704 PRIO=2
JOB_ID=10703 PRIO=1
JOB_ID=10702 PRIO=0
Reset and test job priorities

Fix memory leak in previous patch.

Bug 5479

Coverity 188464

The format for this field is "<inst>:<svc_id>:<comp_id>"; if inst or svc_id
are unset then they're blank, and the parsing code had assumed they would
always be blank as the systems slurmsmwd were developed on never used them.

Bug 5411.

Prevents job priorities from being lowered to 0 or from underflowing.

Bug 5165

Bug 5231

Change slurmctld/controller.c's purge_thread_lock from static to
global extern, so the mutex can be used in slurmctld/job_mgr.c

slurm_cond_signal() needs to always be wrapped in the same mutex as
slurm_cond_[timed]wait(), or else there is a possibility that
slurm_cond_signal() will trigger before slurm_cond_[timed]wait()
is even listening, most likely causing a deadlock.

Bug 5703

initialize old fairshare association pointer correctly.

Bug 5744

Bug 5458

Bug 5403

sinfo output in this test is grouping all nodes together in one
output line (e.g. "nid[000001-000099'), while the data used to
have one node per line. Adding the "-N" option to the test returns
the output to one node per line, as required for the test to work.

Bug 5750

Bug 5748

Bug 5775

# Conflicts:
#	src/common/slurmdbd_defs.c

Bug 5544

Bug 5544

Bug 5613

Surrounding with spaces ensures the closing paren isn't accidentally
included in the link.

Bug 5463.

Now slurmctld will fatal if the two incompatible memory enforcement mechanisms
are configured at the same time (JobAcctGather + task/cgroup). Also, a new info
message in slurmctld startup will indicate if there are not any configured
mechanism.

Bug 5479

MemLimitEnforce and setting NoOverMemoryKill kills the job, or the job step
respectivelly if the memory is exceeded at some point based on JobAcctGather
plugin information, in a JobAcctGatherFreq frequency basis.

Both are incompatible with task/cgroup memory enforcement. The defaults have
been changed to not setting any mechanism, and info/fatal messages added
accordingly to give useful info to the admin. Moreover NoOverMemoryKill has
been deprecated in favor of OverMemoryKill and a fix on the detection of job
memory confinement has been included.

Bug 5479

Bug 5574

Bug 5762