Bug 4252

Bug 4252

CID 177939.

when dealing with this scenario.

If any component of a pack job launch fails, then fail all components

If any node in any component of a job fails, make all components of the
  job fail

only the fields we care about from the database instead of always getting
everything.

The function should probably be a extern so we can use it in other packing.
But that will wait for some future day.

Requires a bit of shuttling around to pass the sbcast_cred_arg_t
to where it's needed. Adds additional checks that someone hasn't
managed to steal an sbcast credential somehow by comparing uid/gid
between auth header and the cred.

Remove some stray xfree(gids) calls that cause a double-free; before
the gids were fetched only for this call path, but now they're
handled as part of the cred.

It's not clear how this would ever happen - there is no
'sbcast --no-alloc', and 'srun --no-alloc --bcast' doesn't work.

Don't keep looking them up on each step / sbcast cred creation.
If they're not there, then slurmd will fill them in for us.

(Same technique used on user_name field.)

Much tidier. Should have done that many commits ago.

I'm tired of doing this manually.

Use new uid_to_string_or_null call instead; slurmd will fill in
if the lookup on the controller fails.

Adjust _rpc_prolog to handle the lack of a set user_name field,
as this was always set to something before.

And safe to/from state files, and send as part of job_info_t.

This is not always set, but if set can avoid a lookup call.

Create it by using the code from uid_to_string, making uid_to_string
use this but do the null handling logic before returning.

Send ngids/gids if requested by config. Make sure to
free the correct values here.

Formatting only; no functional changes.

And deal with marshelling them around the various structs.

A functional change for once. :)

No functional change, just gets a tab stop back.

Shuffle around the calling paths to make use of this instead
of passing in everything as an argument.

Again - no function changes implied, just further groundwork.

It's already accessible through req.

Setup 17.11 RPC format blocks while here, but leave them identical to
the previous format. Also get rid of the temporary len variable.

No functional change, as long as protocol_version has been set correctly.