Non-operators are not permitted to submit jobs with a negative
nice value. Rather than silently reset the value, reject it outright.

Without moving the function, it is undefined when referenced

Bug 6286

This reverts commit 082c59dd.

Bug 6286

Continuation of 6fc7298f

Bug 6286

The key and keylen are already cached inside uthash's
UT_hash_handle. So the memory is wasted.
Bug 6620

Hash functions no longer take the bucket as parameter.
Use of the HASH_FCN can be changed, since the
1,000,000 parameters is not needed. The hash is used for
comparison.
Bug 6620

Under some conditions the requested 4 tasks could not land 2 per
node. This change explicitly sets --ntasks-per-node=2 so it should
always work.

This fixes 24c04bce. Related commit c8c9694f.

Bug 3808
Bug 6681

without this change the task distribution logic errors out and
quite a few regression tests fail

Bug 6409.

Needs to use the acctg_freq argument, instead of snagging optarg
from the global environment. Since this function is exclusively used
inside a getopt_long() loop, this still managed to function correctly.

Correction to commit 72ff192a
test17.19 was failing consistently

I neglected to add a pre4 section after tagging pre3.

Because we skip select_p_select_nodeinfo_set(), we never needed to use
this data, keeping it can be confusing (e.g. backtraces).

Bug 6437

And SALLOC_WAIT as well.

Not serialized into RPC, so do not bother collecting it.

Change it so that we can resize arrays conveniently. Renaming
similarly to slurm_xcalloc().

This name is something of my own invention - there is no direct libc
equivalent that will resize allocations and ensure the contents are
zero'd out, let alone for arrays, and reallocarray() itself is
already non-standard.

Add an extra bool argument so we can introduce try_xcalloc() while here.

EMUNGE_CRED_REPLAYED is expected, and we should still mark the credential
as verified.

The bug here is that g_slurm_auth_verify was still returning SLURM_SUCCESS,
while the credential internally had verify = false, resulting in
g_slurm_auth_get_*() hitting an assertion failure.

Bug 6676.

This used to be the short form for --account, but was changed to
-A ahead of the Slurm 2.1 release over nine years ago.

Otherwise slurmctld will lazily initialize it later when any
auth plugin calls are made, but this can leave you with an unusable
slurmctld if AuthType is invalid.

Used to select between different authentication plugins.

Identifies which authentication plugin (as identified by the index
rather than the plugin_id) was used to decode this specific
credential. Needed so that code paths responding to this message
can reply with the same authentication type to ensure the message
can be accepted by the remote (which, except for the slurmctld/slurmdbd,
will always be a single plugin type.

Standardize on DEFUNCT_RPC_#### for numbers that are reusable.
Or DBD_DEFUNCT_RPC_#### in slurmdbd_defs.h.

The 19.05 release is the second after 17.11, so we no longer need this.

These were all missing a copy of msg->conn into the response_msg,
which implies they were broken for persistent connections before this.

This also catches a number of locations where flags were not
being propogated across to the response.