Which fixes yet another missing slurm_attr_destroy.

Change function signature as the only error path out of here
was if the thread creation failed. Cleanup code in fed_mgr.c
trying to manage that event. (The one other calling path just
ignored the error anyways.)

And another missing slurm_attr_destroy call.

Interestingly enough there was a missing slurm_attr_destroy() call here.

While here fix two function signatures, as the only error
path was if pthread_create failed, and the calling locations
ignored the return code anyways.

Bug 4163.

Set to fatal on pthread_create failure, as this is the LCD of all
existing behaviors, and as such if something were stopping thread
creation from succeeding you could expect some code path to trip
that eventually. Rather than gamble on when/if that is triggered,
just immediately die.

Bug 4163.

CID 44819.

A second PMI2_Init() within the same step is invalid, and cannot succeed.

Return an error code back to the client end, and close the fd to force the
step to terminate immediately.

Due to a bug in our libpmi code, just returning a cmd=response_to_init with
an appropriate rc number will not tear down the connection properly, so
send back something else that will trigger the error path.

Bug 3520.

Need to make a local copy of the user_name field, otherwise
you'll xfree() the cache's version and eventually crash or
fatal() slurmctld.

An error message was changed to report job ID. Modify the output
  parsing to avoid confusing the job ID with a task id label.

A request to cancel a pack step leader will result in that step
  being cancelled on all pack job components. Needed by MPI.

CID 45178.

This reverts commit c03194bc.

Already verified on code paths leading into here, add xassert for posterity.

CID 171465.

Their existence is already assumed (and should be enforced) elsewhere,
so do this once and simplify the remaining code.

CID 161183.

CID 171490.

CID 171485.

CID 171478.

mpi/pmi2 plugin - vestigial pointer could be referenced at shutdown with
    invalid memory reference resulting.

Coverity CID 44677

This reduces the frequency of failures due to timing issues related
to NFS down to about 1% on smd

Coverity CID 44669, 44670

Coverity CID 44699

Coverity CID 44730

Coverity CID 44966

Coverity CID 44770

No other change to logic, but this allowed some code reuse