- 2 x Integer handling issues (CONSTANT_EXPRESSION_RESULT)

Warning flag -Wempty-body in clang-3.7 now errors on this, split
macro definition up over multiple lines to silence.

new glibc 2.24+ that depricates readdir_r.

Otherwise blade_cnt is potentially greater than
bit_size(jobinfo->blade_map) which leads to an assertion failure.

Bug 3033.

Was incorrectly translating request to job.extern if part of a
comma-separate list.

Bug 2890.

variable initialization lost in removing some debugging

Fix for invalid array pointer when creating advanced reservation when job
    allocations span heterogeneous nodes (differing core or socket counts).
bug 2876

it.

This reverts commit 7843e158.

Conflicts:
	NEWS

doesn't have a parent.

Prevent job stuck in configuring state if slurmctld daemon restarted while
    PrologSlurmctld is running.
bugs 2789 and 2810

can work on a BGAS node.

Bug 2806

Except return 0 if using the -u argument. Bug introduced by addb3574,
fix bug 2330 differently while solving bug 2807.

of continuously printing the message over and over as the problem will
most likely not resolve itself.

Bug 2797

Make sure that /proc/#/stat file is NULL terminated to avoid
having sscan() go off the end of a buffer.
bug 2234

While here, mark options const, and add leading underscore to denote this
as a static function (only called within hostlist.c). Also change strcmp
to xstrcmp.

Commit a6ffef22 changed this function and would alter the input hn,
which led to subsequent calls to the function having wrong prefix
lengths for that hostrange precluding it from matching correctly.

Bug 2558.

The buffer to be used for reading the system /proc/*/stat files
is moved from the stack to the heap (i.e. malloc'ed memory) and
initialized to zero, and increased in size from 1k to 4k.
I don't see how this could make any difference, but this anomaly
was reported by valgrind.
bug 2234

The #define of SLURMSTEPD_MEMCHECK in src/slurmd/common/slurmstepd_init.h
must be changed to enable memcheck or valgrind. Also change a #if in
src/slurmd/slurmd/req.c near where you find the "valgrind" references.
Bug 2334 diagnostics

'the the' is is a a mistake mistake.

Wrong order of operations results in the return code being 0/1.

If the plugin ever returns an error the variables weren't initialized so
when they were freed they could corrupt memory.

Bug 2790

>= 15.08 for some reports.

Prevents correct error handling by rc being 0/1 instead of the original
return code.

Also fix slurm_send_only_controller_msg and slurm_send_only_node_msg
although these only result in bad printed values in the debug message.

Bug 2120

This bug was introduced by commit 21c52d2f
which fixed a different problem tracking resources associated with suspended
jobs. There are subtle differences between jobs that are suspended by a
user/administrator and jobs suspended by gang scheduling which resulted in
undercounting allocated CPUs when a job suspended by gang scheduling
was active at the same time of a slurmctld reconfiguration request.
See bugs 2353 (original bug related to commit 21c52d2f
and bug 2765