No change in logic

Change some of the "cpu" references to "core" references as appropriate.
  more places requiring change exist, but this is a start to the needed
  changes.
Remove unused cpu_count argument from gres_plugin_job_test()
Remove unused cpu_cnt parameter to gres_plugin_step_alloc()

Change "cons_res" references to "cons_tres"

Also eliminate some possible fatal errors on reconfig or internal error

If two arrays differ in size, make them the same size to
perform bit_or/and/and_not operations on the full array

create src/common/tres_frequency.[ch] module based upon cpu_frequency.[ch]
modify launch RPCs to pass the value from slurmctld to slurmstepd
validate --gpu-freq value from salloc, sbatch, and srun

Add v18.08 versions of un/pack functions for REQUEST_LAUNCH_TASKS
and REQUEST_BATCH_JOB_LAUNCH RPCs

Use tres_per_job/node/socket/task instead

Completely remove "gres" field from step record in slurmctld and
step info message. Use "tres_per_node", "tres_per_socket", etc.

This bug was introduced in commit 4a9bffe1
Test12.7 was resulting in the logging of error messages of this sort:
sacct: error: slurmdb_ave_tres_usage: couldn't make tres_list from ''
This was due to the tres_usage_in_ave and tres_usage_out_ave fields
being empty ('\0') if the job's cpu count is zero, which makes
calculation of averages impossible.
bug 2782

Bug 5174.

Since having 'nocreate' would override the following option:
create 640 slurm root

Bug 5174.

Add node_features plugin function "node_features_p_reboot_weight()" to
   return the node weight to be used for a compute node that requires reboot
   for use (e.g. to change the NUMA mode of a KNL node).
Add NodeRebootWeight parameter to knl.conf configuration file.

If ReturnToService=2 is configured, the test could generate an error
changing node state to resume after setting it to down. The reason
is if the node communicates with slurmctld, then its state will
automatically be changed from down to idle and resuming an idle
node triggers an error.

Bug 5168.

Previously the default paths continued to be tested even when new ones
were requested. This had as a consequence that if any of the new paths
was the same as any of the default ones (i.e. /usr or /usr/local), the
configure script was incorrectly erroring out specifying that a version
of PMIx was already found in a previous path.

Bug 5168.

Variable initialization plus cosmetic work

Rename gres_per_job for step to gres_per_step
Remove job gres gres_name_type_id field
Build step gres data structure

Prevent run-away jobs

This is not currently supported and no date for support has been set.

If burst_buffer.conf has GetSysState configured to a non-standard
location, but GetSysStatus is not configured that is likely indicative
of a bad configuration rather than a Slurm failure.

Gracefully fail if salloc does not get job allocation

Introduced in bf4cb0b1.