All of these were pre-existing Coverity errors, but I changed nearby
code, variable names, etc. so they looked like new errors.

Coverity reported problem, CID 45194

CID 44936

Coverity CID 171494

variables

This restores perl API operation after commit aea2f0e2

Bug 3956.

Add translation code for the RPCs as well.

Bug 3956.

Add pack_job_id and pack_job_offset to accounting database.
Modified sacct to accept pack job ID specification using "#+#" notation.
Modified sstat to accept pack job ID specification using "#+#" notation.

NULL is returned if the token is not found, testing against '\0'
is wrong (although does work okay in older compilers).

Fixes new GCC 7.1 warning.

was matching more than expected.

error messages that aren't really errors.

Related to Bug 3997

Without this change, each component would generate separate
  email at job begin, end, etc.

If the pack job allocation partially failed, properly handle accounting
  and deallocation of burst buffer. Note, this should rarely happen.

Bug 3999

Default to 1, unless set to 0. Allow to be set to 0 even if
GroupUpdateTime was not set before.

Move down to alphabetical position in read_config.c as well.

Bug 3956.

Fix bug in selection of GRES bound to specific CPUs where the GRES count
    is 2 or more. Previous logic could allocate CPUs not available to the job.

bug 4029

NULL is returned if the token is not found, testing against '\0'
is wrong (although does work okay in older compilers).

Fixes new GCC 7.1 warning.

Highlight the need to use Slurm abstract CPU ID

When the node isn't actually rebooted, the BootTime isn't updated and
Slurm doesn't consider that the node is returned to service, even
if slurmd is responding.

Bug 4039

This will be fixed before 17.11, but is being left as-is on 17.02.

Bug 3956.

to have 'socket=' in AuthInfo to work.

This is to make it so people don't have to update their slurmdbd.conf's
when upgrading (and to match documentation).

Continuation of last commit

Bug 4009

connection.

Bug 4009

jobcomp/elasticsearch saves/load the state to/from elasticsearch_state.  Since
the jobcomp API isn't designed with save/load state operations, the plugin
_save_state() isn't extern and not available from outside the plugin itself,
thus it is highly coupled to fini() function. This state doesn't follow the
same execution path as the rest of Slurm states, where in save_all_sate()
they are all independently scheduled. So we save it manually here on a RPC
of type REQUEST_CONTROL.

This enables that when the Primary ctld issues a REQUEST_CONTROL to the Backup
which is currently in controller mode, the Backup will save the state and when
the Primary assumes control again it can process the saved pending jobs.  The
other way around was already controlled, because when the Primary is running
in controller mode and the Backup issues a REQUEST_CONTROL, the Primary is
shutdown and when breaking the ctld main() function while(1) loop, there was
already a g_slurm_jobcomp_fini() call in place.

Bug 3908