From ea621ec4

Reported by Clang

Add retry on file open fail and remove some unnecessary sleeps

** CID 175193: (FORWARD_NULL)

Theoretically we shouldn't have a job_desc_msg_t without an associated
part_record, but just in case let's harden the code.

Introduced in previous commit: 24365514.

If portions of a pack job launch fail, then release the full
  job allocation rather than having srun exit with outstanding
  job allocations.

Bug 4132

Initially job mem limits were tested at submission time through
_validate_min_mem_partition() -> _valid_pn_min_mem(), but not tested
again at scheduling time, thus leading to jobs incorrectly being scheduled
against partitions where the job exceeded their MaxMemPer* limit
(which can in turn be inherited from the system wide limit too).

NOTE: New WAIT_PN_MEM_LIMIT job_state_reason enum component added to support
this new waiting reason.

Bug 2291.

Modify step create logic so that call components of a heterogeneous job
      launched by a single srun command have the same step ID value.

checked on submit.

This only mattered when submitting a job to multiple partitions.

Bug 4066

on node 0.

Bug 4035

Prevent a heterogeneous job allocation from including the same nodes in
      multiple components (required by MPI jobs spanning components).

Add the xassert() that the inline version has to _remove_job_hash().

To avoid a reliance on the slurm.conf file (as this command is
designed to help you construct said file) the path to check the
space was hard-coded as /tmp. But, if TmpFS is meant to be elsewhere
we'd emit the wrong value here.

Bug 3272.

A lot of slurmdbd operations are authenticated by the accounting_storage
plugin, rather than in slurmdbd. To allow the drop_priv flag to work it
must be checked in is_user_min_admin_level() in addition to the various
functions in proc_req.c .

If SLURM_TESTSUITE_DROP_PRIV is defined (regardless of the value),
set SLURM_DROP_PRIV in the message header so the slurmctld/slurmdbd
will treat the request as if issued from an unprivileged user account.

Bug 4080.

See prior commit da1d3858.

Bug 4080.

This reverts commit 46a46b91.

This reverts commit a2134b14.

This reverts commit 29fe710d.

This reverts commit 47dad9e8.

On second thought, we should be using these or quite similar functions.

This reverts commit a44ef130.

Make error specify the same option name as on srun input

Check for an invalid pack group value before checking for nothing
  to start

Will be removed in 17.11, and 'sgj_job' is a typo anyways.

A lot of slurmdbd operations are authenticated by the accounting_storage
plugin, rather than in slurmdbd. To allow the drop_priv flag to work it
must be checked in is_user_min_admin_level() in addition to the various
functions in proc_req.c .

The drop_priv symbol needs to be accessible from common_as.c,
which is compiled in with the accounting_storage/mysql plugin.

Since that plugin can run in slurmdbd, or directly from slurmctld and
the user commands, the only way to get drop_priv there consistently
is to move the declaration to some common ground behind all of them.

Rather than expose this throughout, just explicitly import it with
'extern' in the appropriate locations.

If SLURM_TESTSUITE_DROP_PRIV is defined (regardless of the setting),
set SLURM_DROP_PRIV in the message header so the slurmctld will treat
the request as if issued from an unprivileged user account.

Bug 4080.

See prior commit da1d3858.

Bug 4080.