The conditional for handling --overcommit was not sufficient to prevent
other option combinations from using that code path, resulting in
unexpected resource allocation behavior. Correct that to check that
overcommit is enabled.

Bug 5345.

Bug 5379.

This does change a network RPC after 18.08.0rc1, which is best to be
avoided. But other recent changes have already broken RPC compatibility
between what will be 18.08.0, so we might as well land this now.

Bug 5443.

And add into appropriate pack and unpack functions.

And set it in launch_prolog().

In cases when you have a range first and then a single afterwards:

nid00[446-447],nid00392

It only worked correctly if it were reversed like so:

nid00392,nid00[446-447]

No functional change.

No function change here, identical to 17.11 protocol block.

Bug 5524

Basically count was never getting over 3 so none of the "end" code
was ever happening.

# Conflicts:
#	src/slurmctld/fed_mgr.c

running.

Bug 5624

for an allocation.

Bug 5293

Backport of 9a507584 in 18.08.

return a start and end time set to the window end time, so elapsed
time is 0.

Bug 5372

This has never been officially documented, and we would rather
see sites use preempt/qos instead.

Bug 5628.

Bug 5619

Tim approved

Bug 5618

Development continues on the master branch for 19.05, but the
snapshot here should not be used and is thus being removed.

Remove the commented-out documentation as well.

# Conflicts:
#	NEWS

Bug 5608

Tim approved

If the dbd comes up after a job array has been submitted to the
controller, the controller calls _update_job_tres() which calls
assoc_mgr_set_tres_cnt_array() which allocates memory for the job's
tres_alloc_cnt. The job array gets scheduled, but job_array_split()
doesn't NULL out the pending job's tres_alloc_cnt, so both the array
task and the pending array job are pointing to the same memory. The
array task calls job_set_alloc_tres() which free's the running job's
tres_alloc_cnt and now the pending array job is pointing to bad memory
and when the array splits again the new array task tries to free
tres_alloc_cnt in job_set_alloc_tres() and segfaults.

Bug 5604

Update slurm.spec and slurm.spec-legacy as well.

This will need to be revisited perhaps link to libslurmfull.so instead
since we will need symbols not exported.

See bug 5605

The previous commit causes erroneous errors to be printed.

test2.14 was made a victim of it.

# Conflicts:
#	src/plugins/jobacct_gather/common/common_jag.c

Bug 5561.

Bug 5538

Bug 5538

This will be handled further in bug 5602

Previous behavior was confusing, and the code path hard to follow.
Rework, and clarify the established behavior in the appropriate man pages.

Bug 4514.